From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wen Congyang Subject: Re: [RFC PATCH COLO v5 08/29] tools/libxl: Introduce bitops macros Date: Thu, 23 Apr 2015 19:56:01 +0800 Message-ID: <5538DDD1.1050700@cn.fujitsu.com> References: <1427870525-18686-1-git-send-email-yanghy@cn.fujitsu.com> <1427870525-18686-9-git-send-email-yanghy@cn.fujitsu.com> <1429715411.30934.36.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1429715411.30934.36.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Yang Hongyang Cc: wei.liu2@citrix.com, eddie.dong@intel.com, yunhong.jiang@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, rshriram@cs.ubc.ca List-Id: xen-devel@lists.xenproject.org On 04/22/2015 11:10 PM, Ian Campbell wrote: > On Wed, 2015-04-01 at 14:41 +0800, Yang Hongyang wrote: >> From: Wen Congyang >> >> This is the same set used by libxc. > > What is this for? > > libxl already exposes a fairly complete libxl_bitmap type and helpers > for use in its own interfaces and by its users. > > For libxl's internal purposes (i.e. to interact with libxc) I don't see > why it can't just use xc_bitops.h. I just need it to get/test the dirty page bitmaps. So libxl_bitmap cannot be used directly. If IIRC, we only can use the header file under the directory tools/libxc/include. Is it OK to move xc_bitops.h to tools/libxc/include? Thanks Wen Congyang > > Ian. > > . >