From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Thiébaud Weksteen" <thiebaud@weksteen.fr>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/gdb: Add command to check list consistency
Date: Thu, 23 Apr 2015 14:20:03 +0200 [thread overview]
Message-ID: <5538E373.5070009@siemens.com> (raw)
In-Reply-To: <5538E142.2090507@siemens.com>
On 2015-04-23 14:10, Jan Kiszka wrote:
> On 2015-04-22 09:32, Thiébaud Weksteen wrote:
>> + nb = 0
>> + list_head_ptr_type = list_head.get_type().pointer()
>> + c = head.cast(list_head_ptr_type)
>
> Why casting? Is it a common use case to not have the list head as a
> variable at hand? The user could still do
>
> lx_list_check (struct list_head *)0x...
>
> when needed.
Specifically, this fails in a non-obvious way right now:
(gdb) lx-check-list workqueues
If you look at lx_thread_info, e.g., it accepts both objects and pointers.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2015-04-23 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 7:32 [PATCH] scripts/gdb: Add command to check list consistency Thiébaud Weksteen
2015-04-23 12:10 ` Jan Kiszka
2015-04-23 12:20 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5538E373.5070009@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thiebaud@weksteen.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.