From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH v4 3/3] xentrace: Implement cpu mask range
 parsing of human values (-c).
Date: Thu, 23 Apr 2015 14:51:09 +0100
Message-ID: <5538F8CD.6070000@eu.citrix.com>
References: <1428108183-28538-1-git-send-email-konrad.wilk@oracle.com>
	<1428108183-28538-4-git-send-email-konrad.wilk@oracle.com>
	<1429100805.15516.252.camel@citrix.com>
	<20150423133124.GA2569@l.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <George.Dunlap@citrix.com>) id 1YlHXB-00078L-D8
	for xen-devel@lists.xenproject.org; Thu, 23 Apr 2015 13:51:17 +0000
In-Reply-To: <20150423133124.GA2569@l.oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Ian Campbell <ian.campbell@citrix.com>
Cc: ian.jackson@citrix.com, wei.liu2@citrix.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On 04/23/2015 02:31 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, Apr 15, 2015 at 01:26:45PM +0100, Ian Campbell wrote:
>> On Fri, 2015-04-03 at 20:43 -0400, Konrad Rzeszutek Wilk wrote:
>>> Instead of just using -c 0x<some hex value> we can
>>> also use: -c <starting cpu>-<end cpu>, -c <cpu1>,<cpu2>, or a
>>> combination of them, or 'all' for all cpus.
>>>
>>> This new format can include just singular CPUs: -c <cpu1>,
>>> or ranges without an start or end (and xentrace will figure out
>>> the values), such as: -c -<cpu2> (which will include cpu0, cpu1,
>>> and cpu2) or -c <cpu2>- (which will include cpu2 and up to MAX_CPUS).
>>>
>>> That should make it easier to trace the right CPU if
>>> using this along with 'xl vcpu-list'.
>>>
>>> The code has been lifted from the Linux kernel, see file
>>> lib/bitmap.c, function __bitmap_parselist.
>>>
>>> To make the old behavior and the new function work, we check
>>> to see if the arguments have '0x' in them. If they do
>>> we use the old style parsing (limited to 32 CPUs). If that
>>> does not exist we use the new parsing.
>>>
>>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>> ---
>>> [v4: Fix per George's review]
>>> [v5: Redo per George's review]
>>
>> I'll leave final word on this one to George.
> 
> OK.
> 
> George, I just reposted this one under v4.1 without any changes
> (see http://lists.xen.org/archives/html/xen-devel/2015-04/msg02702.html).
> 
> Please review this one or the other one.

I had *just* downloaded and started to look at that patch.  At least you
caught me early. :-)

 -George