diff for duplicates of <55390FC5.2070202@linaro.org> diff --git a/a/1.txt b/N1/1.txt index 4a86eef..63a7a3d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -9,7 +9,8 @@ On 04/23/2015 04:11 PM, Nishanth Menon wrote: >>>>> registers for the alarm follow that. When we program Alarm interrupt >>>>> enable prior to programming the time, it is possible that previous >>>>> time value could be close or match at the time of alarm enable ->>>>> resulting in interrupt trigger which is unexpected (and does not match +>>>>> resulting in interrupt trigger which is unexpected (and does not matc= +h >>>>> the time we expect it to trigger). >>>>> >>>>> To prevent this scenario from occuring, program the ALM0_EN bit only @@ -18,7 +19,8 @@ On 04/23/2015 04:11 PM, Nishanth Menon wrote: >>>>> Ofcourse, I2C programming is non-atomic, so there are loopholes where >>>>> the interrupt wont trigger if the time requested is in the past at >>>>> the time of programming the ALM0_EN bit. However, we will not have ->>>>> unexpected interrupts while the time is programmed after the interrupt +>>>>> unexpected interrupts while the time is programmed after the interrup= +t >>>>> are enabled. >>>> >>>> I think it will be nice if you will mention that you going to follow @@ -61,42 +63,42 @@ On 04/23/2015 04:11 PM, Nishanth Menon wrote: >>> 2. Write 0x47 to the Alarm0 Minutes register >>> [0x0B]. >>> 3. Write 0x71 to the Alarm0 Hours register [0x0C] ->>> – 11 hours in 12-hour format. ->>> 4. Write 0x72 to the Alarm0 Day register [0x0D] – +>>> =E2=80=93 11 hours in 12-hour format. +>>> 4. Write 0x72 to the Alarm0 Day register [0x0D] =E2=80=93 >>> Tuesday + Alarm Polarity Low + Match on all. >>> The Alarm0 Interrupt Flag is also cleared. >>> 5. Write 0x14 to the Alarm0 Date register [0x0E]. >>> 6. Write 0x08 to the Alarm0 Month register [0x0F]. >>> With all the Alarm0 registers set we can now activate >>> the Alarm0 on the Control register. ->>> 7. Write 0x10 to the Control register [0x07] – +>>> 7. Write 0x10 to the Control register [0x07] =E2=80=93 >>> Alarm0 enabled no CLKOUT, Alarm1 disabled >>> >>> before this patch we do ( http://pastebin.ubuntu.com/10863880/) ->>> CONTROL r[7] = 0x90 (OUT=1, ALM0EN=1) ->>> OSCTRIM r[8] = 0x00 ->>> EEUNLOCK r[9] = 0x00 ->>> ALM0SEC r[A] = 0x01 ->>> ALM0MIN r[B] = 0x45 ->>> ALM0HOUR r[C] = 0x23 ->>> ALM0WKDAY r[D] = 0x75 <-ALMOIF is cleared ->>> ALM0DATE r[E] = 0x09 ->>> ALM0MTH r[F] = 0x04 ->>> RSRVED r[10] = 0x01 +>>> CONTROL r[7] =3D 0x90 (OUT=3D1, ALM0EN=3D1) +>>> OSCTRIM r[8] =3D 0x00 +>>> EEUNLOCK r[9] =3D 0x00 +>>> ALM0SEC r[A] =3D 0x01 +>>> ALM0MIN r[B] =3D 0x45 +>>> ALM0HOUR r[C] =3D 0x23 +>>> ALM0WKDAY r[D] =3D 0x75 <-ALMOIF is cleared +>>> ALM0DATE r[E] =3D 0x09 +>>> ALM0MTH r[F] =3D 0x04 +>>> RSRVED r[10] =3D 0x01 >>> >>> with this patch, we do: ->>> burst( CONTROL r[7] = 0x80 (OUT=1) ->>> OSCTRIM r[8] = 0x00 ->>> EEUNLOCK r[9] = 0x00 ->>> ALM0SEC r[A] = 0x01 ->>> ALM0MIN r[B] = 0x45 ->>> ALM0HOUR r[C] = 0x23 ->>> ALM0WKDAY r[D] = 0x75 <-ALMOIF is cleared ->>> ALM0DATE r[E] = 0x09 ->>> ALM0MTH r[F] = 0x04 ->>> RSRVED r[10] = 0x01 +>>> burst( CONTROL r[7] =3D 0x80 (OUT=3D1) +>>> OSCTRIM r[8] =3D 0x00 +>>> EEUNLOCK r[9] =3D 0x00 +>>> ALM0SEC r[A] =3D 0x01 +>>> ALM0MIN r[B] =3D 0x45 +>>> ALM0HOUR r[C] =3D 0x23 +>>> ALM0WKDAY r[D] =3D 0x75 <-ALMOIF is cleared +>>> ALM0DATE r[E] =3D 0x09 +>>> ALM0MTH r[F] =3D 0x04 +>>> RSRVED r[10] =3D 0x01 >>> ) ->>> CONTROL r[7] = 0x90 (OUT=1, ALM0EN=1) +>>> CONTROL r[7] =3D 0x90 (OUT=3D1, ALM0EN=3D1) >>> >>> Which is slightly unoptimal way of what the app note recommends. - as >>> I mentioned earlier in this thread, I will try and do optimizations in @@ -115,6 +117,19 @@ On 04/23/2015 04:11 PM, Nishanth Menon wrote: Reviewed-by: Grygorii Strashko <grygorii.strashko@linaro.org> --- +--=20 regards, -grygorii + +--=20 +--=20 +You received this message because you are subscribed to "rtc-linux". +Membership options at http://groups.google.com/group/rtc-linux . +Please read http://groups.google.com/group/rtc-linux/web/checklist +before submitting a driver. +---=20 +You received this message because you are subscribed to the Google Groups "= +rtc-linux" group. +To unsubscribe from this group and stop receiving emails from it, send an e= +mail to rtc-linux+unsubscribe@googlegroups.com. +For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N1/content_digest index b7a56af..50dc060 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\05538C6C2.5010508@linaro.org\0" "ref\05538EF8D.5050209@ti.com\0" "From\0Grygorii.Strashko@linaro.org <grygorii.strashko@linaro.org>\0" - "Subject\0Re: [PATCH V2] drivers/rtc/rtc-ds1307.c: Enable the mcp794xx alarm after programming time\0" + "Subject\0[rtc-linux] Re: [PATCH V2] drivers/rtc/rtc-ds1307.c: Enable the mcp794xx alarm after programming time\0" "Date\0Thu, 23 Apr 2015 18:29:09 +0300\0" "To\0Nishanth Menon <nm@ti.com>" Grygorii.Strashko@linaro.org <grygorii.strashko@linaro.org> @@ -26,7 +26,8 @@ ">>>>> registers for the alarm follow that. When we program Alarm interrupt\n" ">>>>> enable prior to programming the time, it is possible that previous\n" ">>>>> time value could be close or match at the time of alarm enable\n" - ">>>>> resulting in interrupt trigger which is unexpected (and does not match\n" + ">>>>> resulting in interrupt trigger which is unexpected (and does not matc=\n" + "h\n" ">>>>> the time we expect it to trigger).\n" ">>>>>\n" ">>>>> To prevent this scenario from occuring, program the ALM0_EN bit only\n" @@ -35,7 +36,8 @@ ">>>>> Ofcourse, I2C programming is non-atomic, so there are loopholes where\n" ">>>>> the interrupt wont trigger if the time requested is in the past at\n" ">>>>> the time of programming the ALM0_EN bit. However, we will not have\n" - ">>>>> unexpected interrupts while the time is programmed after the interrupt\n" + ">>>>> unexpected interrupts while the time is programmed after the interrup=\n" + "t\n" ">>>>> are enabled.\n" ">>>>\n" ">>>> I think it will be nice if you will mention that you going to follow\n" @@ -78,42 +80,42 @@ ">>> 2. Write 0x47 to the Alarm0 Minutes register\n" ">>> [0x0B].\n" ">>> 3. Write 0x71 to the Alarm0 Hours register [0x0C]\n" - ">>> \342\200\223 11 hours in 12-hour format.\n" - ">>> 4. Write 0x72 to the Alarm0 Day register [0x0D] \342\200\223\n" + ">>> =E2=80=93 11 hours in 12-hour format.\n" + ">>> 4. Write 0x72 to the Alarm0 Day register [0x0D] =E2=80=93\n" ">>> Tuesday + Alarm Polarity Low + Match on all.\n" ">>> The Alarm0 Interrupt Flag is also cleared.\n" ">>> 5. Write 0x14 to the Alarm0 Date register [0x0E].\n" ">>> 6. Write 0x08 to the Alarm0 Month register [0x0F].\n" ">>> With all the Alarm0 registers set we can now activate\n" ">>> the Alarm0 on the Control register.\n" - ">>> 7. Write 0x10 to the Control register [0x07] \342\200\223\n" + ">>> 7. Write 0x10 to the Control register [0x07] =E2=80=93\n" ">>> Alarm0 enabled no CLKOUT, Alarm1 disabled\n" ">>>\n" ">>> before this patch we do ( http://pastebin.ubuntu.com/10863880/)\n" - ">>> \tCONTROL r[7] = 0x90 (OUT=1, ALM0EN=1)\n" - ">>> \tOSCTRIM r[8] = 0x00\n" - ">>> \tEEUNLOCK r[9] = 0x00\n" - ">>> \tALM0SEC r[A] = 0x01\n" - ">>> \tALM0MIN r[B] = 0x45\n" - ">>> \tALM0HOUR r[C] = 0x23\n" - ">>> \tALM0WKDAY r[D] = 0x75 <-ALMOIF is cleared\n" - ">>> \tALM0DATE r[E] = 0x09\n" - ">>> \tALM0MTH r[F] = 0x04\n" - ">>> \tRSRVED r[10] = 0x01\n" + ">>> \tCONTROL r[7] =3D 0x90 (OUT=3D1, ALM0EN=3D1)\n" + ">>> \tOSCTRIM r[8] =3D 0x00\n" + ">>> \tEEUNLOCK r[9] =3D 0x00\n" + ">>> \tALM0SEC r[A] =3D 0x01\n" + ">>> \tALM0MIN r[B] =3D 0x45\n" + ">>> \tALM0HOUR r[C] =3D 0x23\n" + ">>> \tALM0WKDAY r[D] =3D 0x75 <-ALMOIF is cleared\n" + ">>> \tALM0DATE r[E] =3D 0x09\n" + ">>> \tALM0MTH r[F] =3D 0x04\n" + ">>> \tRSRVED r[10] =3D 0x01\n" ">>>\n" ">>> with this patch, we do:\n" - ">>> burst(\tCONTROL r[7] = 0x80 (OUT=1)\n" - ">>> \tOSCTRIM r[8] = 0x00\n" - ">>> \tEEUNLOCK r[9] = 0x00\n" - ">>> \tALM0SEC r[A] = 0x01\n" - ">>> \tALM0MIN r[B] = 0x45\n" - ">>> \tALM0HOUR r[C] = 0x23\n" - ">>> \tALM0WKDAY r[D] = 0x75 <-ALMOIF is cleared\n" - ">>> \tALM0DATE r[E] = 0x09\n" - ">>> \tALM0MTH r[F] = 0x04\n" - ">>> \tRSRVED r[10] = 0x01\n" + ">>> burst(\tCONTROL r[7] =3D 0x80 (OUT=3D1)\n" + ">>> \tOSCTRIM r[8] =3D 0x00\n" + ">>> \tEEUNLOCK r[9] =3D 0x00\n" + ">>> \tALM0SEC r[A] =3D 0x01\n" + ">>> \tALM0MIN r[B] =3D 0x45\n" + ">>> \tALM0HOUR r[C] =3D 0x23\n" + ">>> \tALM0WKDAY r[D] =3D 0x75 <-ALMOIF is cleared\n" + ">>> \tALM0DATE r[E] =3D 0x09\n" + ">>> \tALM0MTH r[F] =3D 0x04\n" + ">>> \tRSRVED r[10] =3D 0x01\n" ">>> )\n" - ">>> \tCONTROL r[7] = 0x90 (OUT=1, ALM0EN=1)\n" + ">>> \tCONTROL r[7] =3D 0x90 (OUT=3D1, ALM0EN=3D1)\n" ">>>\n" ">>> Which is slightly unoptimal way of what the app note recommends. - as\n" ">>> I mentioned earlier in this thread, I will try and do optimizations in\n" @@ -132,8 +134,21 @@ "\n" "Reviewed-by: Grygorii Strashko <grygorii.strashko@linaro.org>\n" "\n" - "-- \n" + "--=20\n" "regards,\n" - -grygorii + "-grygorii\n" + "\n" + "--=20\n" + "--=20\n" + "You received this message because you are subscribed to \"rtc-linux\".\n" + "Membership options at http://groups.google.com/group/rtc-linux .\n" + "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" + "before submitting a driver.\n" + "---=20\n" + "You received this message because you are subscribed to the Google Groups \"=\n" + "rtc-linux\" group.\n" + "To unsubscribe from this group and stop receiving emails from it, send an e=\n" + "mail to rtc-linux+unsubscribe@googlegroups.com.\n" + For more options, visit https://groups.google.com/d/optout. -4a1b3fa0234bb86d81fc5aea3357fac83befd4bc03884c1e69e34476c8b8bb1b +62a5cfcca6fded7fa96bdfad403961a21ee1c0ad83a67a649a1384e42707b9dc
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.