From: Jens Axboe <axboe@kernel.dk>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Mike Miller <mike.miller@hp.com>, Don Brace <don.brace@pmcs.com>,
iss_storagedev@hp.com, storagedev@pmcs.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cciss: Optimize scan_thread
Date: Thu, 23 Apr 2015 10:51:59 -0600 [thread overview]
Message-ID: <5539232F.4050404@kernel.dk> (raw)
In-Reply-To: <1429728220.10273.26.camel@stgolabs.net>
On 04/22/2015 12:43 PM, Davidlohr Bueso wrote:
> Two rather small optimizations found while going through driver
> code:
>
> 1) Use the cheaper alternative to set_current_state() as we are
> sure the task will block right afterward.
>
> 2) Checks for list_empty without the scan_mutex. The list_empty
> function is very much designed to work without locks, obviously
> as long as the head (scan_q) is reliable. In this case if another
> thread is doing add_to_scan_list(), we still buckle in the outer
> loop, so it will be caught upon the next iteration -- and if
> kthread_should_stop() hits, it does not matter _anyway_ as we'd
> still need to abort the function regardless of the status of
> the scan_q.
Not that it's wrong, but this is mostly some unneeded optimizations.
It's not like this is in a hot path.
--
Jens Axboe
next prev parent reply other threads:[~2015-04-23 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 18:43 [PATCH] cciss: Optimize scan_thread Davidlohr Bueso
2015-04-23 16:51 ` Jens Axboe [this message]
2015-04-23 17:06 ` Davidlohr Bueso
2015-04-23 17:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5539232F.4050404@kernel.dk \
--to=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=don.brace@pmcs.com \
--cc=iss_storagedev@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.miller@hp.com \
--cc=storagedev@pmcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.