From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Elder Subject: Re: [PATCH 0/3] rbd: header read/refresh improvements Date: Fri, 24 Apr 2015 10:03:56 -0500 Message-ID: <553A5B5C.9070909@ieee.org> References: <553A411A.8060902@ieee.org> <9D2825F1-BA75-433E-9B92-63D405339F0E@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pd0-f173.google.com ([209.85.192.173]:35451 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070AbbDXPD7 (ORCPT ); Fri, 24 Apr 2015 11:03:59 -0400 Received: by pdbqd1 with SMTP id qd1so51347740pdb.2 for ; Fri, 24 Apr 2015 08:03:59 -0700 (PDT) In-Reply-To: <9D2825F1-BA75-433E-9B92-63D405339F0E@redhat.com> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Douglas Fuller , Ilya Dryomov Cc: Ceph Development On 04/24/2015 09:40 AM, Douglas Fuller wrote: > >> On Apr 24, 2015, at 10:17 AM, Ilya Dryomov >> wrote: >> >> On Fri, Apr 24, 2015 at 4:11 PM, Alex Elder >> wrote: >>> On 04/23/2015 02:06 PM, Douglas Fuller wrote: >>>> >>>> Support multiple class op calls in one ceph_msg and consolidate >>>> rbd header read and refresh processes to use this feature to >>>> reduce the number of ceph_msgs sent for that process. Refresh >>>> features on header refresh and begin returning EIO if features >>>> have changed since mapping. >>>> >>>> Douglas Fuller (3): ceph: support multiple class method calls >>>> in one ceph_msg rbd: combine object method calls in header >>>> refresh using fewer ceph_msgs rbd: re-read features during >>>> header refresh and detect changes. >>>> >>>> drivers/block/rbd.c | 518 >>>> +++++++++++++++++++++++++++++----------- >>>> include/linux/ceph/osd_client.h | 3 +- net/ceph/messenger.c >>>> | 4 + net/ceph/osd_client.c | 92 ++++++- 4 files >>>> changed, 470 insertions(+), 147 deletions(-) >>>> >>> >>> In case Ilya or others don't get to it soon, I plan to review >>> this series tomorrow. >> >> I was planning take a look while I'm the road during the weekend. >> >> Doug, from a quick look this revision still has a bunch of style >> issues, most notably the alignment of function parameters and >> braces around if / else. See Documentation/CodingStyle in the >> kernel tree for examples. > > I needed to put out v2 in part because I squashed a couple fixup > commits in the wrong place, leaving some things behind in #2 that > were corrected in #3. > > I changed the braces in that version, but the function parameter > indents are inconsistent throughout the code. I=E2=80=99ll try to com= e up > with a compromise. When in doubt, lean toward the style used in the rest of the kernel. I used a few conventions that are not consistent with that in a lot of places, and those can be gradually phased toward what's recommended for the kernel. Some examples are: sizeof x or sizeof (x) --> sizeof(x) (cast) foo --> (cast)foo White space under comment blocks static int\nfunction(...) -> static int function(...) -Alex >> >> You might also want to run your patches through >> scripts/checkpatch.pl, but take it with a grain of salt - it can be >> a bit too extreme at times. No need to post v3 with just style >> fixes, wait for more feedback. > > Thanks again for all feedback. > >> >> Thanks, >> >> Ilya > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html