From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36889)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YlfPI-0004Zr-HU
	for qemu-devel@nongnu.org; Fri, 24 Apr 2015 11:20:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YlfPD-0004jO-S6
	for qemu-devel@nongnu.org; Fri, 24 Apr 2015 11:20:44 -0400
Message-ID: <553A5F0E.8050502@redhat.com>
Date: Fri, 24 Apr 2015 17:19:42 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <cover.1429885069.git.berto@igalia.com>
	<e96826c89daa1d0e623ddd527df087987209ad46.1429885069.git.berto@igalia.com>
In-Reply-To: <e96826c89daa1d0e623ddd527df087987209ad46.1429885069.git.berto@igalia.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 08/11] qemu-iotests: add no-op streaming
	test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 24.04.2015 17:01, Alberto Garcia wrote:
> This patch tests that in a partial block-stream operation, no data is
> ever copied from the base image.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>   tests/qemu-iotests/030     | 18 ++++++++++++++++++
>   tests/qemu-iotests/030.out |  4 ++--
>   2 files changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030
> index 6e6cb5a..bc53885 100755
> --- a/tests/qemu-iotests/030
> +++ b/tests/qemu-iotests/030
> @@ -91,6 +91,24 @@ class TestSingleDrive(iotests.QMPTestCase):
>                            qemu_io('-f', iotests.imgfmt, '-c', 'map', test_img),
>                            'image file map does not match backing file after streaming')
>   
> +    def test_stream_no_op(self):
> +        self.assert_no_active_block_jobs()
> +
> +        # The image map is empty before the operation
> +        empty_map = qemu_io('-f', iotests.imgfmt, '-c', 'map', test_img)

Oh, that was too obvious. :-)

Reviewed-by: Max Reitz <mreitz@redhat.com>

> +
> +        # This is a no-op: no data should ever be copied from the base image
> +        result = self.vm.qmp('block-stream', device='drive0', base=mid_img)
> +        self.assert_qmp(result, 'return', {})
> +
> +        self.wait_until_completed()
> +
> +        self.assert_no_active_block_jobs()
> +        self.vm.shutdown()
> +
> +        self.assertEqual(qemu_io('-f', iotests.imgfmt, '-c', 'map', test_img),
> +                         empty_map, 'image file map changed after a no-op')
> +
>       def test_stream_partial(self):
>           self.assert_no_active_block_jobs()
>   
> diff --git a/tests/qemu-iotests/030.out b/tests/qemu-iotests/030.out
> index fa16b5c..6323079 100644
> --- a/tests/qemu-iotests/030.out
> +++ b/tests/qemu-iotests/030.out
> @@ -1,5 +1,5 @@
> -.............
> +..............
>   ----------------------------------------------------------------------
> -Ran 13 tests
> +Ran 14 tests
>   
>   OK