diff for duplicates of <553A9123.3010906@cogentembedded.com> diff --git a/a/1.txt b/N1/1.txt index a8dc5ba..b2ad66b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,7 @@ On 04/23/2015 02:22 AM, Florian Fainelli wrote: [...] ->>>> + if (ecmd->duplex = DUPLEX_FULL) +>>>> + if (ecmd->duplex == DUPLEX_FULL) >>>> + priv->duplex = 1; >>>> + else >>>> + priv->duplex = 0; @@ -44,7 +44,7 @@ phy_ethtool_sset(). This check was copied from sh_eth that was fixed by Ben ot to crash due to 'ethtool' being called on closed device, see: -https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/net/ethernet/renesas/sh_eth.c?idO9dce230b32eec45cec8c28cae61efdfa2f7d57 +https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/net/ethernet/renesas/sh_eth.c?id=4f9dce230b32eec45cec8c28cae61efdfa2f7d57 That commit refers to a dangling pointer, not sure what does this mean... The PHy device doesn't seem to be freed by phy_disconnect(). Ben? diff --git a/a/content_digest b/N1/content_digest index 8040e5a..a32cf98 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\055382D4E.5070708@gmail.com\0" "From\0Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>\0" "Subject\0Re: [PATCH v3] Renesas Ethernet AVB driver\0" - "Date\0Fri, 24 Apr 2015 18:53:23 +0000\0" + "Date\0Fri, 24 Apr 2015 21:53:23 +0300\0" "To\0Florian Fainelli <f.fainelli@gmail.com>" robh+dt@kernel.org pawel.moll@arm.com @@ -23,7 +23,7 @@ "\n" "[...]\n" "\n" - ">>>> + if (ecmd->duplex = DUPLEX_FULL)\n" + ">>>> + if (ecmd->duplex == DUPLEX_FULL)\n" ">>>> + priv->duplex = 1;\n" ">>>> + else\n" ">>>> + priv->duplex = 0;\n" @@ -65,7 +65,7 @@ " This check was copied from sh_eth that was fixed by Ben ot to crash due to\n" "'ethtool' being called on closed device, see:\n" "\n" - "https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/net/ethernet/renesas/sh_eth.c?idO9dce230b32eec45cec8c28cae61efdfa2f7d57\n" + "https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/net/ethernet/renesas/sh_eth.c?id=4f9dce230b32eec45cec8c28cae61efdfa2f7d57\n" "\n" " That commit refers to a dangling pointer, not sure what does this mean...\n" "The PHy device doesn't seem to be freed by phy_disconnect(). Ben?\n" @@ -141,4 +141,4 @@ "\n" WBR, Sergei -d4ea00900d2261333fe121618d94433d323fb12d25dd87827e1ad63a76fbf0b9 +b01533595ef35e73392f5da4946b4fff71d9892fdc94fe4cd0abf3bd5056176b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.