diff for duplicates of <553AA3C2.7090404@cogentembedded.com> diff --git a/a/1.txt b/N1/1.txt index 3da677a..b20da8f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -35,8 +35,7 @@ this patch. :-) >> 1 file changed, 19 insertions(+), 13 deletions(-) >> Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pinctrl.c ->> =================================================================== ->> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pinctrl.c +>> =================================>> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pinctrl.c >> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pinctrl.c >> @@ -571,33 +571,39 @@ static const struct pinconf_ops sh_pfc_p >> /* PFC ranges -> pinctrl pin descs */ @@ -58,7 +57,7 @@ this patch. :-) >> + i < pfc->info->nr_pins; i++, info++) { >> + if (info->enum_id || info->configs) -> Why do you need to test info->configs as well ? I thought enum_id == 0 is +> Why do you need to test info->configs as well ? I thought enum_id = 0 is > always reserved, am I getting it wrong ? Look at SH_PFC_PIN_NAMED() and its users. @@ -104,7 +103,7 @@ this can be changed... >> + pmx->pctl_desc.npins = ret; >> >> pmx->pctl = pinctrl_register(&pmx->pctl_desc, pfc->dev, pmx); ->> if (pmx->pctl == NULL) +>> if (pmx->pctl = NULL) > Shouldn't you also fix sh_pfc_init_ranges() ? It includes the following code > that doesn't seem to handle holes properly. diff --git a/a/content_digest b/N1/content_digest index 00c35e4..376d12e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\03656925.3GuTRhx1fV@avalon\0" "From\0Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>\0" "Subject\0Re: [PATCH] sh-pfc: handle pin array holes in sh_pfc_map_pins()\0" - "Date\0Fri, 24 Apr 2015 23:12:50 +0300\0" + "Date\0Fri, 24 Apr 2015 20:12:50 +0000\0" "To\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Cc\0linus.walleij@linaro.org" linux-sh@vger.kernel.org @@ -46,8 +46,7 @@ ">> 1 file changed, 19 insertions(+), 13 deletions(-)\n" "\n" ">> Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pinctrl.c\n" - ">> ===================================================================\n" - ">> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pinctrl.c\n" + ">> =================================>> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pinctrl.c\n" ">> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pinctrl.c\n" ">> @@ -571,33 +571,39 @@ static const struct pinconf_ops sh_pfc_p\n" ">> /* PFC ranges -> pinctrl pin descs */\n" @@ -69,7 +68,7 @@ ">> +\t i < pfc->info->nr_pins; i++, info++) {\n" ">> +\t\tif (info->enum_id || info->configs)\n" "\n" - "> Why do you need to test info->configs as well ? I thought enum_id == 0 is\n" + "> Why do you need to test info->configs as well ? I thought enum_id = 0 is\n" "> always reserved, am I getting it wrong ?\n" "\n" " Look at SH_PFC_PIN_NAMED() and its users.\n" @@ -115,7 +114,7 @@ ">> +\tpmx->pctl_desc.npins = ret;\n" ">>\n" ">> \tpmx->pctl = pinctrl_register(&pmx->pctl_desc, pfc->dev, pmx);\n" - ">> \tif (pmx->pctl == NULL)\n" + ">> \tif (pmx->pctl = NULL)\n" "\n" "> Shouldn't you also fix sh_pfc_init_ranges() ? It includes the following code\n" "> that doesn't seem to handle holes properly.\n" @@ -134,4 +133,4 @@ "\n" WBR, Sergei -e824d4393b86bc3a942d7977695a30ca7425ccaef82e31b5b504cec2c2ea6b37 +0638824e17cdc3f4c9fe7515f648303b867373574c86986e14d869bd1c1aaccf
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.