From: "Andreas Färber" <afaerber@suse.de>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: agraf@suse.de, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK
Date: Sat, 25 Apr 2015 19:05:55 +0200 [thread overview]
Message-ID: <553BC973.2030506@suse.de> (raw)
In-Reply-To: <1429975686-19494-1-git-send-email-ehabkost@redhat.com>
Am 25.04.2015 um 17:28 schrieb Eduardo Habkost:
> The QJSON code used casts to (QJSON*) directly, instead of OBJECT_CHECK.
> There were even some functions using object_dynamic_cast() calls
> followed by assert(), which is exactly what OBJECT_CHECK does (by
> calling object_dynamic_cast_assert()).
Suggest s/OBJECT_CHECK/OBJECT_CHECK()/g everywhere for clarity.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> qjson.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Andreas Färber <afaerber@suse.de>
Wasn't aware QJSON is using QOM - assuming this will go through some
QAPI/QMP tree.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-04-25 17:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-25 15:28 [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK Eduardo Habkost
2015-04-25 17:05 ` Andreas Färber [this message]
2015-04-27 17:23 ` Eduardo Habkost
2015-04-29 12:38 ` Luiz Capitulino
2015-04-29 12:46 ` Andreas Färber
2015-04-29 12:54 ` Luiz Capitulino
2015-04-29 12:55 ` Eduardo Habkost
2015-04-29 13:00 ` Luiz Capitulino
2015-05-01 16:19 ` Michael Roth
2015-05-01 16:23 ` Michael Roth
2015-05-02 14:44 ` Alexander Graf
2015-04-29 19:18 ` Paolo Bonzini
2015-05-01 12:04 ` Eduardo Habkost
2015-05-05 12:43 ` Juan Quintela
2015-05-05 12:53 ` Luiz Capitulino
2015-05-05 13:32 ` Juan Quintela
2015-05-01 17:16 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553BC973.2030506@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.