From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 05/19] xen: arm: Add and use r/o+raz and w/o+wi helpers Date: Sat, 25 Apr 2015 22:16:40 +0500 Message-ID: <553BCBF8.4070107@citrix.com> References: <1429279300.25195.330.camel@citrix.com> <1429279315-32143-5-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1429279315-32143-5-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: julien.grall@linaro.org, tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 17/04/2015 19:01, Ian Campbell wrote: > Signed-off-by: Ian Campbell > --- > v2: Move last paramter of a handle_ro_raz call to next patch where it > belongs. > --- > xen/arch/arm/traps.c | 52 ++++++++++++++++++++++++++++++++------------------ > 1 file changed, 33 insertions(+), 19 deletions(-) > > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c > index 8b1846a..b54aef6 100644 > --- a/xen/arch/arm/traps.c > +++ b/xen/arch/arm/traps.c > @@ -1587,6 +1587,34 @@ static void handle_raz_wi(struct cpu_user_regs *regs, > advance_pc(regs, hsr); > } > > +/* Write only + write ignore */ [..] > +/* Read only + read as zero */ I'm not sure if we finished the discussion on those comment on v1 before you sent the v2. The "+" is very confusing for me because it indicates two parts: write only and write ignore (same for the read). Both part doesn't really fit together. Although this helper clearly choose to implement WO as WI (resp. RO as RAZ). I think this should be clearer in order to avoid people think this can be used for RO but with a different value than 0. Regards, -- Julien Grall