From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v2 12/19] xen: arm: Annotate the handlers
 for HSTR_EL2.T15
Date: Sat, 25 Apr 2015 22:48:09 +0500
Message-ID: <553BD359.3000104@citrix.com>
References: <1429279300.25195.330.camel@citrix.com>
	<1429279315-32143-12-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1429279315-32143-12-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: julien.grall@linaro.org, tim@xen.org, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 17/04/2015 19:01, Ian Campbell wrote:
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> v2: s/Tx/T15/
> ---
>   xen/arch/arm/traps.c |   10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index a2bae51..86b5655 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -1720,6 +1720,11 @@ static void do_cp15_32(struct cpu_user_regs *regs,
>        * ARMv7 (DDI 0406C.b): B1.14.12
>        * ARMv8 (DDI 0487A.d): N/A
>        *
> +     * HSTR_EL2.T15
> +     *
> +     * ARMv7 (DDI 0406C.b): B1.14.14
> +     * ARMv8 (DDI 0487A.d): D1-1507 Table D1-55
> +     *
>        * And all other unknown registers.
>        */
>       default:
> @@ -1758,6 +1763,11 @@ static void do_cp15_64(struct cpu_user_regs *regs,
>        * ARMv7 (DDI 0406C.b): B1.14.12
>        * ARMv8 (DDI 0487A.d): N/A
>        *
> +     * HSTR_EL2.Tx

Should not this Tx switch to T15 too?

Regards,

-- 
Julien Grall