From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH 6/9] x86/intel_pstate: the main boby of the
 intel_pstate driver
Date: Sat, 25 Apr 2015 23:05:58 +0500
Message-ID: <553BD786.6060802@citrix.com>
References: <1461419884-6091-1-git-send-email-wei.w.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1461419884-6091-1-git-send-email-wei.w.wang@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Wang <wei.w.wang@intel.com>, jbeulich@suse.com, andrew.cooper3@citrix.com, ian.campbell@citrix.com, kevin.tian@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org
Cc: yang.z.zhang@intel.com
List-Id: xen-devel@lists.xenproject.org

Hi Wei,

On 23/04/2016 18:58, Wei Wang wrote:
> diff --git a/xen/include/acpi/cpufreq/processor_perf.h b/xen/include/acpi/cpufreq/processor_perf.h
> index d8a1ba6..ebff11d 100644
> --- a/xen/include/acpi/cpufreq/processor_perf.h
> +++ b/xen/include/acpi/cpufreq/processor_perf.h
> @@ -7,6 +7,7 @@
>
>   #define XEN_PX_INIT 0x80000000
>
> +int intel_pstate_init(void);

The intel pstate driver is x86 specific. Although xen/include/acpi 
contains common headers for common code.

Can you move the declaration in an x86 specific header (i.e in 
xen/include/asm-x86)?

If I'm not mistaken, you have other patch with similar things in this 
series.

Regards,

-- 
Julien Grall