From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com ([209.85.212.173]:36221 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385AbbDZIJ3 (ORCPT ); Sun, 26 Apr 2015 04:09:29 -0400 Received: by wizk4 with SMTP id k4so66074322wiz.1 for ; Sun, 26 Apr 2015 01:09:28 -0700 (PDT) Message-ID: <553C9D33.2030005@gmail.com> Date: Sun, 26 Apr 2015 10:09:23 +0200 From: Dirk Behme MIME-Version: 1.0 To: Greg KH CC: stable@vger.kernel.org Subject: Re: [PATCH for 3.19.y to 3.10.y] net: sysctl_net_core: remove unused variable one References: <1430032263-5094-1-git-send-email-dirk.behme@gmail.com> <20150426071958.GA31992@kroah.com> In-Reply-To: <20150426071958.GA31992@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On 26.04.2015 09:19, Greg KH wrote: > On Sun, Apr 26, 2015 at 09:11:03AM +0200, Dirk Behme wrote: >> Back porting the upstream commit b1cb59cf2efe7 ("net: sysctl_net_core: check >> SNDBUF and RCVBUF for min length") to -stable introduces a compiler warning >> >> net/core/sysctl_net_core.c:26:12: warning: ‘one’ defined but not used [-Wunused-variable] >> static int one = 1; >> >> While upstream has an additional user of the variable 'one' after that commit >> ("tstamp_allow_data"), -stable doesn't have any user of 'one' any more, resulting >> in above compiler warning. Or in other words: -stable doesn't have the >> commit b245be1f4db1a0 ("net-timestamp: no-payload only sysctl") introducing the >> additional user of 'one'. >> >> Fix the compiler warning by removing the unused variable. > > No, this was done on purpose, sorry, I can't take this patch. The > network maintainer wants it this way to be easier to backport things. > > We can live with the compiler warning. Would it be an option to pick b245be1f4db1a0 ("net-timestamp: no-payload only sysctl") then, too? Thanks Dirk