From: Alex Elder <elder@ieee.org>
To: Douglas Fuller <dfuller@redhat.com>, Sage Weil <sage@newdream.net>
Cc: Ilya Dryomov <idryomov@gmail.com>,
Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [PATCHv2 0/3] rbd: header read/refresh improvements
Date: Sun, 26 Apr 2015 23:40:14 -0500 [thread overview]
Message-ID: <553DBDAE.7080603@ieee.org> (raw)
In-Reply-To: <DAE9CF5D-1D64-4A73-9469-DA2EDC00F69D@redhat.com>
On 04/26/2015 11:35 PM, Douglas Fuller wrote:
> This solution just feels hacky and inefficient, so I think there is a
> desire to feel like we at least tried to come up something simpler
> and more efficient before proceeding.
Right. And somehow more fitting with the existing code, if
that's possible. There are a few things in this proposal
that are just special case code, and it would be nice to
avoid that.
I'm sorry I've been too busy today to get back to this. I spent
a lot of time on Saturday getting ramped back up on this code
so I could provide a decent review...
I'm going to at least look at the code (error on a read op)
before going to bed, so I at least know what the problem is.
I'll try to have something to say (even if it's "I've got
nothing") in the next day or two.
-Alex
next prev parent reply other threads:[~2015-04-27 4:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 13:22 [PATCHv2 0/3] rbd: header read/refresh improvements Douglas Fuller
2015-04-24 13:22 ` [PATCHv2 1/3] ceph: support multiple class method calls in one ceph_msg Douglas Fuller
2015-04-24 13:22 ` [PATCHv2 2/3] rbd: combine object method calls in header refresh using fewer ceph_msgs Douglas Fuller
2015-04-24 13:22 ` [PATCHv2 3/3] rbd: re-read features during header refresh and detect changes Douglas Fuller
2015-04-26 6:29 ` [PATCHv2 0/3] rbd: header read/refresh improvements Alex Elder
2015-04-26 8:44 ` Ilya Dryomov
2015-04-26 14:28 ` Douglas Fuller
2015-04-26 14:39 ` Alex Elder
2015-04-26 15:07 ` Douglas Fuller
2015-04-27 4:15 ` Sage Weil
2015-04-27 4:35 ` Douglas Fuller
2015-04-27 4:40 ` Alex Elder [this message]
2015-05-07 15:28 ` Alex Elder
2015-05-07 16:48 ` Douglas Fuller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553DBDAE.7080603@ieee.org \
--to=elder@ieee.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dfuller@redhat.com \
--cc=idryomov@gmail.com \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.