Re: [PATCH 3/3] can: flexcan: Add support for non RX-FIFO mode and ERRATA ERR005829

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1827 bytes --]

On 04/27/2015 08:51 AM, bhupesh.sharma@freescale.com wrote:

>>> The errata list is not available for public access on www.freescale.com
>> so far.
>>> The next version of LS1021A SoC, is fixing this bug and since both are
>>> supposed to be used by customers, the kconfig trick is required to
>>> turn-off this handling for one version, while keeping it intact for the
>> other.
>>
>> Sorry, a compile time switch is not an option here. Please configure it
>> during runtime via the device tree. This can be done by different
>> compatibles, one for the broken another one for the fixed SoC.
>  
> Well, most of the code is written to handle this on run-time (on basis
> of the dts). Maybe I can create two versions of fsl_ls1021a_devtype_data rather
> than using the kConfig:
> 
> For the broken- SoC:
> static struct flexcan_devtype_data fsl_ls1021a_devtype_data = {
> 	.features = FLEXCAN_HAS_V10_FEATURES | FLEXCAN_HAS_MECR_FEATURES
> 	| FLEXCAN_USES_RX_MB
> 	,
> };
> 
> and for the new-SoC:
> static struct flexcan_devtype_data fsl_ls1021a_devtype_data = {
> 	.features = FLEXCAN_HAS_V10_FEATURES | FLEXCAN_HAS_MECR_FEATURES
> 	,
> };

Yes - use two different variables for this and assign them to two
compatible entries.

> Note that the legacy (non-RX FIFO mode) should work on all the FlexCAN variants,
> so this a feature which some-one can expose/hide as per their use-case, as long
> as the driver supports both the Rx-FIFO and non-RX-FIFO mode legs.

Sure, but not via a compile time switch.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]