From: Michael Tokarev <mjt@tls.msk.ru>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] libcacard: use the library?
Date: Mon, 27 Apr 2015 12:44:52 +0300 [thread overview]
Message-ID: <553E0514.5030700@msgid.tls.msk.ru> (raw)
Currently we link individual object files from libcacard
to qemu-system binaries, this way (from Makefile.objs):
libcacard-y += libcacard/cac.o libcacard/event.o
libcacard-y += libcacard/vcard.o libcacard/vreader.o
...
common-obj-$(CONFIG_SMARTCARD_NSS) += $(libcacard-y)
Why can't we use the actual library, and just add the
linker flag, -Ilibcacard -lcacard?
libcacard is built only when libtool is found, which
is kinda illogical since libtool is not needed to link
these object files with qemu. And libtool is already
used (if found) to link qemu binaries, so using it to
link binaries with libcacard is already done.
How about replacing these common-obj-$(CONFIG_SMARTCARD_NSS)
with appropriate linker flags, and doing that only for
these binaries which actually need libcacard?
Thanks,
/mjt
next reply other threads:[~2015-04-27 9:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 9:44 Michael Tokarev [this message]
2015-04-27 9:49 ` [Qemu-devel] libcacard: use the library? Daniel P. Berrange
2015-04-27 9:54 ` Michael Tokarev
2015-04-27 10:00 ` Peter Maydell
2015-04-27 10:37 ` Paolo Bonzini
2015-06-17 18:25 ` Michael Tokarev
2015-06-17 19:26 ` Paolo Bonzini
2015-06-17 20:15 ` Michael Tokarev
2015-06-18 8:09 ` Paolo Bonzini
2015-06-18 8:11 ` Michael Tokarev
2015-06-18 8:18 ` Paolo Bonzini
2015-06-18 9:07 ` Markus Armbruster
2015-06-18 9:27 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553E0514.5030700@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.