From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [Qemu-devel] [PATCH v5 06/17] target-s390x: Introduce S390 CPU facilities Date: Mon, 27 Apr 2015 12:14:19 +0200 Message-ID: <553E0BFB.3050205@de.ibm.com> References: <1428933396-37887-1-git-send-email-mimu@linux.vnet.ibm.com> <1428933396-37887-7-git-send-email-mimu@linux.vnet.ibm.com> <553DEF39.7070800@de.ibm.com> <20150427105512.65c33cb3@bee> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150427105512.65c33cb3@bee> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Michael Mueller Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Eduardo Habkost , Gleb Natapov , Alexander Graf , Daniel Hansel , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Richard Henderson , Andreas Faerber List-ID: Am 27.04.2015 um 10:55 schrieb Michael Mueller: > On Mon, 27 Apr 2015 10:11:37 +0200 > Christian Borntraeger wrote: > >> Am 13.04.2015 um 15:56 schrieb Michael Mueller: >> [...] >>> + FAC_TRANSACTIONAL_EXE = 73, >>> + /* >>> + * The store-hypervisor-information facility #74 is >>> + * z/VM related and when added to be handled by QEMU >>> + * when hosted on LPAR. (see: SC24-6179-05 page 953) >>> + */ >> >> I find this sentence hard to read. >> > > I would not mind to fully skip it then. Maybe just add + /* z/VM-specific, see: SC24-6179-05 page 953) */ + FAC_STHYI = 74, but do not use? From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ymg3Z-0005iC-4s for qemu-devel@nongnu.org; Mon, 27 Apr 2015 06:14:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ymg3V-000411-Um for qemu-devel@nongnu.org; Mon, 27 Apr 2015 06:14:29 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:52344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ymg3V-0003zN-L0 for qemu-devel@nongnu.org; Mon, 27 Apr 2015 06:14:25 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 27 Apr 2015 11:14:24 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7A4E9219005E for ; Mon, 27 Apr 2015 11:14:04 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t3RAELFh9306490 for ; Mon, 27 Apr 2015 10:14:21 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t3RAEJcs019243 for ; Mon, 27 Apr 2015 04:14:21 -0600 Message-ID: <553E0BFB.3050205@de.ibm.com> Date: Mon, 27 Apr 2015 12:14:19 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1428933396-37887-1-git-send-email-mimu@linux.vnet.ibm.com> <1428933396-37887-7-git-send-email-mimu@linux.vnet.ibm.com> <553DEF39.7070800@de.ibm.com> <20150427105512.65c33cb3@bee> In-Reply-To: <20150427105512.65c33cb3@bee> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 06/17] target-s390x: Introduce S390 CPU facilities List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Mueller Cc: linux-s390@vger.kernel.org, Eduardo Habkost , kvm@vger.kernel.org, Gleb Natapov , qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, Cornelia Huck , Alexander Graf , "Jason J. Herne" , Daniel Hansel , Paolo Bonzini , Andreas Faerber , Richard Henderson Am 27.04.2015 um 10:55 schrieb Michael Mueller: > On Mon, 27 Apr 2015 10:11:37 +0200 > Christian Borntraeger wrote: > >> Am 13.04.2015 um 15:56 schrieb Michael Mueller: >> [...] >>> + FAC_TRANSACTIONAL_EXE = 73, >>> + /* >>> + * The store-hypervisor-information facility #74 is >>> + * z/VM related and when added to be handled by QEMU >>> + * when hosted on LPAR. (see: SC24-6179-05 page 953) >>> + */ >> >> I find this sentence hard to read. >> > > I would not mind to fully skip it then. Maybe just add + /* z/VM-specific, see: SC24-6179-05 page 953) */ + FAC_STHYI = 74, but do not use?