From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46176)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YmgPj-00015a-Qo
	for qemu-devel@nongnu.org; Mon, 27 Apr 2015 06:37:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YmgPf-0003Z2-Ug
	for qemu-devel@nongnu.org; Mon, 27 Apr 2015 06:37:23 -0400
Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]:33886)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YmgPf-0003Yt-NT
	for qemu-devel@nongnu.org; Mon, 27 Apr 2015 06:37:19 -0400
Received: by wgso17 with SMTP id o17so111148399wgs.1
	for <qemu-devel@nongnu.org>; Mon, 27 Apr 2015 03:37:19 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <553E115B.40303@redhat.com>
Date: Mon, 27 Apr 2015 12:37:15 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <553E0514.5030700@msgid.tls.msk.ru>
In-Reply-To: <553E0514.5030700@msgid.tls.msk.ru>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] libcacard: use the library?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel <qemu-devel@nongnu.org>



On 27/04/2015 11:44, Michael Tokarev wrote:
> Currently we link individual object files from libcacard
> to qemu-system binaries, this way (from Makefile.objs):
> 
> libcacard-y += libcacard/cac.o libcacard/event.o
> libcacard-y += libcacard/vcard.o libcacard/vreader.o
> ...
> common-obj-$(CONFIG_SMARTCARD_NSS) += $(libcacard-y)
> 
> Why can't we use the actual library, and just add the
> linker flag, -Ilibcacard -lcacard?

Because that would require people to use "libtool --mode=execute gdb" to
debug qemu.  This is not a problem for me, but I know that some people
on the list are allergic to the GNU build tools.

I would be okay for this, and I would also be okay with making libcacard
standalone.  Making it standalone would also bypass the problem of
verbose debugging command lines.  You've already done most of the work
with your patches to stop using libqemuutil.a.  As a small step in that
direction, I've sent a patch to remove use of qemu-common.h.

Somebody has to write some Autoconf/Automake and package it up, I guess.

Paolo