From: Michael Tokarev <mjt@tls.msk.ru>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] libcacard: stop including qemu-common.h
Date: Mon, 27 Apr 2015 16:03:42 +0300 [thread overview]
Message-ID: <553E33AE.1040804@msgid.tls.msk.ru> (raw)
In-Reply-To: <553E3322.6020803@msgid.tls.msk.ru>
27.04.2015 16:01, Michael Tokarev пишет:
> 27.04.2015 16:00, Paolo Bonzini wrote:
>> On 27/04/2015 14:36, Michael Tokarev wrote:
>>>> This is a small step towards making libcacard standalone.
>>> No, this does not build, it complains about printf everywhere
>>> and some other things, like atoi. I'll try to make it better,
>>> and maybe to omit glib-compat inclusion too from some places.
>>
>> Weird, it builds here. Must be a different glib.
>
> All the missing includes are in vscclient.c.
stdio.h for printf
string.h for various strcmp etc
stdlib.h for atoi
unistd.h (on *nix) for getopt
It looks like you didn't build vscclient.
next prev parent reply other threads:[~2015-04-27 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 10:34 [Qemu-devel] [PATCH] libcacard: stop including qemu-common.h Paolo Bonzini
2015-04-27 12:36 ` Michael Tokarev
2015-04-27 13:00 ` Paolo Bonzini
2015-04-27 13:01 ` Michael Tokarev
2015-04-27 13:03 ` Michael Tokarev [this message]
2015-04-27 13:04 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553E33AE.1040804@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.