From: Eric Nelson <eric.nelson-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
der.herr-kA1LtwSENNE@public.gmane.org,
lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
bvijay-l0cyMroinI0@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
gigi.joseph-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
eyalr-l0cyMroinI0@public.gmane.org,
robin-/Q/L1SwJa3aEVqv0pETR8A@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
eliad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 2/4] misc: ti-st: use of_get_named_gpio_flags for nshutdown
Date: Mon, 27 Apr 2015 08:26:18 -0700 [thread overview]
Message-ID: <553E551A.8040900@boundarydevices.com> (raw)
In-Reply-To: <20150427084921.GL16501@mwanda>
Thanks Dan,
On 04/27/2015 01:49 AM, Dan Carpenter wrote:
>
> It's not obvious to me what the point of this patch is. Why are we
> making this change? There is no changelog.
>
>> @@ -482,9 +483,9 @@ long st_kim_start(void *kim_data)
>> pdata->chip_enable(kim_gdata);
>>
>> /* Configure BT nShutdown to HIGH state */
>
> These comments are misleading now.
>
Will fix in V2.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-04-27 15:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-25 22:15 [PATCH 1/4] misc: ti-st: use GPIO_LOW for initial value of nshutdown Eric Nelson
[not found] ` <1430000118-26386-1-git-send-email-eric.nelson-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2015-04-25 22:15 ` [PATCH 2/4] misc: ti-st: use of_get_named_gpio_flags for nshutdown Eric Nelson
[not found] ` <1430000118-26386-2-git-send-email-eric.nelson-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2015-04-27 8:49 ` Dan Carpenter
2015-04-27 15:26 ` Eric Nelson [this message]
2015-04-25 22:15 ` [PATCH 3/4] misc: ti-st: don't use NULL pdata Eric Nelson
[not found] ` <1430000118-26386-3-git-send-email-eric.nelson-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2015-04-27 8:52 ` Dan Carpenter
2015-04-27 19:19 ` Eric Nelson
2015-04-27 19:27 ` [PATCH V2 1/4] misc: ti-st: use GPIO_LOW for initial value of nshutdown Eric Nelson
[not found] ` <1430162849-8804-1-git-send-email-eric.nelson-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2015-04-27 19:27 ` [PATCH V2 2/4] misc: ti-st: use of_get_named_gpio_flags for nshutdown Eric Nelson
[not found] ` <1430162849-8804-2-git-send-email-eric.nelson-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2015-04-27 20:11 ` Peter Hurley
[not found] ` <553E97E8.4080103-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2015-04-27 20:18 ` Eric Nelson
[not found] ` <553E99A7.1080206-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2015-04-27 20:29 ` Peter Hurley
2015-04-27 19:27 ` [PATCH V2 3/4] misc: ti-st: don't use NULL pdata Eric Nelson
2015-04-27 19:27 ` [PATCH V2 4/4] Documentation: DT: misc: Add ti-st bindings Eric Nelson
2015-04-25 22:15 ` [PATCH " Eric Nelson
2015-04-28 11:17 ` [PATCH 1/4] misc: ti-st: use GPIO_LOW for initial value of nshutdown Lee Jones
2015-04-28 16:41 ` Eric Nelson
[not found] ` <553FB848.4090802-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2015-04-28 17:56 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553E551A.8040900@boundarydevices.com \
--to=eric.nelson-q5rjgjkts06cy9shamctrueocmrvltnr@public.gmane.org \
--cc=bvijay-l0cyMroinI0@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=der.herr-kA1LtwSENNE@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eliad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org \
--cc=eyalr-l0cyMroinI0@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gigi.joseph-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robin-/Q/L1SwJa3aEVqv0pETR8A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.