From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 03B23E00820; Mon, 27 Apr 2015 08:54:20 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [193.201.172.118 listed in list.dnswl.org] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (picmaster[at]mail.bg) * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mx2.mail.bg (mx2.mail.bg [193.201.172.118]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 314F5E00477 for ; Mon, 27 Apr 2015 08:54:18 -0700 (PDT) Received: from [192.168.0.62] (unknown [93.152.143.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx2.mail.bg (Postfix) with ESMTPSA id 964BB6000E42; Mon, 27 Apr 2015 18:54:17 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mail.bg; s=default; t=1430150057; bh=AksU36cbTHCTTmN92M1wTgJyRWfDAunOIrQ6qa/iQvw=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=QWh29xIeKgq0nhoHIPYkPYXMDTCPXSJzLRvO0wDQF8tFjYLrnZWsGb59SW3at/F1+ hKzPv3XMM/mv7BxC1XWWeg3dH9BSMbdaFtPkPNeeS83HVHU3TOK7Jg6L9Qm6pGSSuR QlVB0BqGiklscJEoRSrXiYQTDi0JkoFNZsTDEDoA= Message-ID: <553E5BA9.3000307@mail.bg> Date: Mon, 27 Apr 2015 18:54:17 +0300 From: Nikolay Dimitrov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Daiane Angolini References: <1430109302-25721-1-git-send-email-picmaster@mail.bg> In-Reply-To: Cc: "meta-freescale@yoctoproject.org" Subject: Re: [meta-fsl-arm-extra][PATCH 1/2] linux-riotboard: Add separate riotboard kernel recipe X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Apr 2015 15:54:20 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Daiane, On 04/27/2015 02:54 PM, Daiane Angolini wrote: > On Mon, Apr 27, 2015 at 1:35 AM, Nikolay Dimitrov wrote: >> Add dedicated RIoTboard kernel recipe for easier maintenance and patch >> cherry-picking. > >> diff --git a/recipes-kernel/linux/linux-riotboard_4.0.bb b/recipes-kernel/linux/linux-riotboard_4.0.bb >> new file mode 100644 >> index 0000000..7ac63fc >> --- /dev/null >> +++ b/recipes-kernel/linux/linux-riotboard_4.0.bb >> @@ -0,0 +1,15 @@ >> +SUMMARY = "Linux kernel for Embest RIoTboard" > > In case you really need a dedicated kernel, please use a DESCRIPTION > and elaborate it. What is the history of this kernel, why do you need > a different kernel, what is the difference of this kernel, and in case > it is really a 4.0 kernel why the chages are not upstreamed are > possible questions to be answerd in the DESCRIPTION. OK, will do. >> + >> +require recipes-kernel/linux/linux-imx.inc >> +require recipes-kernel/linux/linux-dtb.inc >> + >> +DEPENDS += "lzop-native bc-native" >> + >> +SRCBRANCH = "patches-4.0" >> +SRCREV = "48dfc7ce6933a593a651e8ce029cbc5bcca19382" >> + >> +SRC_URI = "git://github.com/Freescale/linux-fslc.git;branch=${SRCBRANCH} \ >> + file://defconfig \ > > I don't understand why are you using the same git repository as > linux-fslc, can you, please elaborate/explain your idea? I wanted to revert a specific linux-fslc patch while still reusing as much code as possible (and not cloning the repo). I can also switch entirely to mainline and stop using linux-fslc, if you think that's an issue. > And, it also means your commit log is weak and you can elaborate it for v2? > > Daiane > >> +" >> + >> +COMPATIBLE_MACHINE = "(imx6dl-riotboard)" >> -- >> 1.7.10.4 >> >> -- Thanks for the feedback. I'll take it into account for v2, once Otavio also acknowledges the need for separate kernel recipe. Regards, Nikolay