From: Rhyland Klein <rklein@nvidia.com>
To: Jonathan Cameron <jic23@kernel.org>,
Roberta Dobrescu <roberta.dobrescu@gmail.com>,
<linux-iio@vger.kernel.org>
Cc: <knaack.h@gmx.de>, <lars@metafoo.de>, <pmeerw@pmeerw.net>,
<daniel.baluta@intel.com>
Subject: Re: [PATCH v2 3/3] staging: iio: light: isl29018: Use standard sysfs attributes for scale and integration time
Date: Mon, 27 Apr 2015 12:03:58 -0400 [thread overview]
Message-ID: <553E5DEE.5020001@nvidia.com> (raw)
In-Reply-To: <553D41CC.6070702@kernel.org>
On 4/26/2015 3:51 PM, Jonathan Cameron wrote:
> On 16/04/15 20:20, Roberta Dobrescu wrote:
>> This patch refactors the isl29018 driver code in order to use standard
>> sysfs attributes for scale and integration time.
>>
>> ISL29018 light sensor uses four ranges and four ADC's resolutions
>> which influence the calculated lux. Adc resolution is strongly
>> connected to integration time and range should be controlled by scale.
>>
>> This patch introduces the usage of integration time and scale instead
>> of adc resolution and range.
>>
>> Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
> Looks good to me, Applied to the togreg branch of iio.git - initially pushed out
> as testing.
>
> cc'd Rhyland though not heard from him for quite a while.
>
> Rhyland, if you are still interested in this driver, give me a shout and I can
> hold these patches back until you get a chance to look at them.
>
> Sorry, forgot to cc you earlier in the discussion!
>
> Jonathan
>
Its fine, don't hold up patches on my account. I haven't looked at this
in a while, so don't gate on me :)
-rhyland
--
nvpublic
next prev parent reply other threads:[~2015-04-27 16:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 19:20 [PATCH v2 0/3] staging: iio: light: isl29018: Remove non-standard sysfs attributes Roberta Dobrescu
2015-04-16 19:20 ` [PATCH v2 1/3] " Roberta Dobrescu
2015-04-26 19:46 ` Jonathan Cameron
2015-04-16 19:20 ` [PATCH v2 2/3] staging: iio: light: isl29018: Rename lux_scale to calibscale Roberta Dobrescu
2015-04-26 19:46 ` Jonathan Cameron
2015-04-16 19:20 ` [PATCH v2 3/3] staging: iio: light: isl29018: Use standard sysfs attributes for scale and integration time Roberta Dobrescu
2015-04-26 19:51 ` Jonathan Cameron
2015-04-27 16:03 ` Rhyland Klein [this message]
2015-05-02 11:02 ` Jonathan Cameron
2015-05-02 15:55 ` Roberta Dobrescu
2015-06-27 9:34 ` Hartmut Knaack
2015-06-29 7:24 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553E5DEE.5020001@nvidia.com \
--to=rklein@nvidia.com \
--cc=daniel.baluta@intel.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=roberta.dobrescu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.