From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: Make local_events_need_delivery working with idle VPCU Date: Mon, 27 Apr 2015 17:13:43 +0100 Message-ID: <553E6037.9000101@citrix.com> References: <1430145540-31032-1-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ymlnb-0005rM-C6 for xen-devel@lists.xenproject.org; Mon, 27 Apr 2015 16:22:23 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , Julien Grall Cc: xen-devel@lists.xenproject.org, Riku Voipio , Tim Deegan , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Hi Tamas, On 27/04/15 16:40, Tamas K Lengyel wrote: > IMHO we should check if op==RELINQUISH || op==MEMACCESS before > calling hypercall_preempt_check. That was a change I made - previously > it was only called if the op was RELINQUISH and not the other way around. I though about it but it make the code a lot uglier. It would be worst if we decide to preempt more operations in the future... Regards, -- Julien Grall