From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Covington Subject: Re: [PATCH v12 3/4] hw/arm/virt: add dynamic sysbus device support Date: Mon, 27 Apr 2015 12:58:35 -0400 Message-ID: <553E6ABB.1070703@codeaurora.org> References: <1429888773-11730-1-git-send-email-eric.auger@linaro.org> <1429888773-11730-4-git-send-email-eric.auger@linaro.org> <553E3C71.1040001@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 85A7B4E928 for ; Mon, 27 Apr 2015 12:50:17 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6m+hFT9wyVYz for ; Mon, 27 Apr 2015 12:50:16 -0400 (EDT) Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 15CE64E8AC for ; Mon, 27 Apr 2015 12:50:15 -0400 (EDT) In-Reply-To: <553E3C71.1040001@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Alexander Graf , Eric Auger , eric.auger@st.com, qemu-devel@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com Cc: alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu, patches@linaro.org List-Id: kvmarm@lists.cs.columbia.edu Hi Alex, On 04/27/2015 09:41 AM, Alexander Graf wrote: >> --- a/hw/arm/virt.c >> +++ b/hw/arm/virt.c >> @@ -131,6 +138,7 @@ static const MemMapEntry a15memmap[] = { >> [VIRT_FW_CFG] = { 0x09020000, 0x0000000a }, >> [VIRT_MMIO] = { 0x0a000000, 0x00000200 }, >> /* ...repeating for a total of NUM_VIRTIO_TRANSPORTS, each of that >> size */ >> + [VIRT_PLATFORM_BUS] = { 0x0c000000, 0x02000000 }, > > Peter, would you have a hard time if we just get rid of VIRT_MMIO completely > and allow users to create the mmio-virtio bridges using -device for -M > virt-2.4 and above? > > At the end of the day, I'm fairly sure people will end up virtio-pci anyway > and it's just a big waste of address space to keep VIRT_MMIO around, no? I'm not sure I have an opinion one way or the other, but I would like to understand the "big waste" argument. Is there something that users are eager to reuse this address space for, like more RAM? Thanks, Chris -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmmMm-0006Dw-E3 for qemu-devel@nongnu.org; Mon, 27 Apr 2015 12:58:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YmmMi-0007W0-Vs for qemu-devel@nongnu.org; Mon, 27 Apr 2015 12:58:44 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58545) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmmMi-0007VT-Ql for qemu-devel@nongnu.org; Mon, 27 Apr 2015 12:58:40 -0400 Message-ID: <553E6ABB.1070703@codeaurora.org> Date: Mon, 27 Apr 2015 12:58:35 -0400 From: Christopher Covington MIME-Version: 1.0 References: <1429888773-11730-1-git-send-email-eric.auger@linaro.org> <1429888773-11730-4-git-send-email-eric.auger@linaro.org> <553E3C71.1040001@suse.de> In-Reply-To: <553E3C71.1040001@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v12 3/4] hw/arm/virt: add dynamic sysbus device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , Eric Auger , eric.auger@st.com, qemu-devel@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com Cc: alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu, patches@linaro.org Hi Alex, On 04/27/2015 09:41 AM, Alexander Graf wrote: >> --- a/hw/arm/virt.c >> +++ b/hw/arm/virt.c >> @@ -131,6 +138,7 @@ static const MemMapEntry a15memmap[] = { >> [VIRT_FW_CFG] = { 0x09020000, 0x0000000a }, >> [VIRT_MMIO] = { 0x0a000000, 0x00000200 }, >> /* ...repeating for a total of NUM_VIRTIO_TRANSPORTS, each of that >> size */ >> + [VIRT_PLATFORM_BUS] = { 0x0c000000, 0x02000000 }, > > Peter, would you have a hard time if we just get rid of VIRT_MMIO completely > and allow users to create the mmio-virtio bridges using -device for -M > virt-2.4 and above? > > At the end of the day, I'm fairly sure people will end up virtio-pci anyway > and it's just a big waste of address space to keep VIRT_MMIO around, no? I'm not sure I have an opinion one way or the other, but I would like to understand the "big waste" argument. Is there something that users are eager to reuse this address space for, like more RAM? Thanks, Chris -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project