From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Date: Tue, 28 Apr 2015 00:35:50 +0000 Subject: Re: [patch] thermal: rockchip: fix an error code Message-Id: <553ED5E6.3090800@rock-chips.com> List-Id: References: <20150421093410.GE12098@mwanda> <55371080.4090307@rock-chips.com> In-Reply-To: <55371080.4090307-TNX95d0MmH7DzftRWevZcw@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dan Carpenter , Zhang Rui , Caesar Wang Cc: Heiko Stuebner , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Anderson , Eduardo Valentin , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Dan, 在 2015年04月22日 11:07, Caesar Wang 写道: > > > 在 2015年04月21日 17:34, Dan Carpenter 写道: >> There is a copy and paste bug, "->clk" vs "->pclk", so we return the >> wrong error code here. >> >> Fixes: cbac8f639437 ('thermal: rockchip: add driver for thermal') >> Signed-off-by: Dan Carpenter >> >> diff --git a/drivers/thermal/rockchip_thermal.c >> b/drivers/thermal/rockchip_thermal.c >> index 3aa46ac..cd8f5f93 100644 >> --- a/drivers/thermal/rockchip_thermal.c >> +++ b/drivers/thermal/rockchip_thermal.c >> @@ -529,7 +529,7 @@ static int rockchip_thermal_probe(struct >> platform_device *pdev) >> thermal->pclk = devm_clk_get(&pdev->dev, "apb_pclk"); >> if (IS_ERR(thermal->pclk)) { >> - error = PTR_ERR(thermal->clk); >> + error = PTR_ERR(thermal->pclk); > Yeah, you are right. > Reviewed-by: Caesar Wang > Tested-by: Caesar Wang > Thanks. > > Caesar >> dev_err(&pdev->dev, "failed to get apb_pclk clock: %d\n", >> error); >> return error; >> >> >> > -- ************************************************************************************** 王晓腾 Caesar Wang Product R&D Dept.III Fuzhou Rockchip Electronics Co.Ltd Addr： NO.18 Building, A District, Fuzhou Software Park,Gulou District,Fuzhou, Fujian,China(Fuzhou Headquarters) 21F,Malata Building,Kejizhongyi Avenue,Nanshan District,Shenzhen (Shenzhen Office) Tel：+86-591-83991906/07 - 8221 Mobile:+86 15059456742 E-mail : wxt@rock-chips.com *************************************************************************************** *************************************************************************************** IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd .The contents of this email and any attachments may contain information that is privileged, confidential and/or exempt from disclosure under applicable law and relevant NDA. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information is STRICTLY PROHIBITED. Please immediately contact the sender as soon as possible and destroy the material in its entirety in any format. Thank you. *************************************************************************************** From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [patch] thermal: rockchip: fix an error code Date: Tue, 28 Apr 2015 08:35:50 +0800 Message-ID: <553ED5E6.3090800@rock-chips.com> References: <20150421093410.GE12098@mwanda> <55371080.4090307@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <55371080.4090307-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Dan Carpenter , Zhang Rui , Caesar Wang Cc: Heiko Stuebner , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Anderson , Eduardo Valentin , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-pm@vger.kernel.org RGFuLAoK5ZyoIDIwMTXlubQwNOaciDIy5pelIDExOjA3LCBDYWVzYXIgV2FuZyDlhpnpgZM6Cj4K Pgo+IOWcqCAyMDE15bm0MDTmnIgyMeaXpSAxNzozNCwgRGFuIENhcnBlbnRlciDlhpnpgZM6Cj4+ IFRoZXJlIGlzIGEgY29weSBhbmQgcGFzdGUgYnVnLCAiLT5jbGsiIHZzICItPnBjbGsiLCBzbyB3 ZSByZXR1cm4gdGhlCj4+IHdyb25nIGVycm9yIGNvZGUgaGVyZS4KPj4KPj4gRml4ZXM6IGNiYWM4 ZjYzOTQzNyAoJ3RoZXJtYWw6IHJvY2tjaGlwOiBhZGQgZHJpdmVyIGZvciB0aGVybWFsJykKPj4g U2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgo+ Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy90aGVybWFsL3JvY2tjaGlwX3RoZXJtYWwuYyAKPj4g Yi9kcml2ZXJzL3RoZXJtYWwvcm9ja2NoaXBfdGhlcm1hbC5jCj4+IGluZGV4IDNhYTQ2YWMuLmNk OGY1ZjkzIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL3RoZXJtYWwvcm9ja2NoaXBfdGhlcm1hbC5j Cj4+ICsrKyBiL2RyaXZlcnMvdGhlcm1hbC9yb2NrY2hpcF90aGVybWFsLmMKPj4gQEAgLTUyOSw3 ICs1MjksNyBAQCBzdGF0aWMgaW50IHJvY2tjaGlwX3RoZXJtYWxfcHJvYmUoc3RydWN0IAo+PiBw bGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4+ICAgICAgICAgdGhlcm1hbC0+cGNsayA9IGRldm1fY2xr X2dldCgmcGRldi0+ZGV2LCAiYXBiX3BjbGsiKTsKPj4gICAgICAgaWYgKElTX0VSUih0aGVybWFs LT5wY2xrKSkgewo+PiAtICAgICAgICBlcnJvciA9IFBUUl9FUlIodGhlcm1hbC0+Y2xrKTsKPj4g KyAgICAgICAgZXJyb3IgPSBQVFJfRVJSKHRoZXJtYWwtPnBjbGspOwo+IFllYWgsIHlvdSBhcmUg cmlnaHQuCj4gUmV2aWV3ZWQtYnk6IENhZXNhciBXYW5nIDx3eHRAcm9jay1jaGlwcy5jb20+Cj4K ClRlc3RlZC1ieTogQ2Flc2FyIFdhbmcgPHd4dEByb2NrLWNoaXBzLmNvbT4KCj4gVGhhbmtzLgo+ Cj4gQ2Flc2FyCj4+ICAgICAgICAgICBkZXZfZXJyKCZwZGV2LT5kZXYsICJmYWlsZWQgdG8gZ2V0 IGFwYl9wY2xrIGNsb2NrOiAlZFxuIiwKPj4gICAgICAgICAgICAgICBlcnJvcik7Cj4+ICAgICAg ICAgICByZXR1cm4gZXJyb3I7Cj4+Cj4+Cj4+Cj4KCi0tIAoqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKgrnjovmmZPohb4gICAgQ2Flc2FyIFdhbmcKUHJvZHVjdCBSJkQgRGVwdC5JSUkKRnV6 aG91IFJvY2tjaGlwIEVsZWN0cm9uaWNzIENvLkx0ZApBZGRy77yaICBOTy4xOCBCdWlsZGluZywg QSBEaXN0cmljdCwgRnV6aG91IFNvZnR3YXJlIFBhcmssR3Vsb3UgRGlzdHJpY3QsRnV6aG91LCBG dWppYW4sQ2hpbmEoRnV6aG91IEhlYWRxdWFydGVycykKICAgICAgICAgICAgICAgMjFGLE1hbGF0 YSBCdWlsZGluZyxLZWppemhvbmd5aSBBdmVudWUsTmFuc2hhbiBEaXN0cmljdCxTaGVuemhlbiAg KFNoZW56aGVuIE9mZmljZSkKVGVs77yaKzg2LTU5MS04Mzk5MTkwNi8wNyAtIDgyMjEKTW9iaWxl Ois4NiAxNTA1OTQ1Njc0MgpFLW1haWwgOiB3eHRAcm9jay1jaGlwcy5jb20KKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqCioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKgpJTVBPUlRB TlQgTk9USUNFOiBUaGlzIGVtYWlsIGlzIGZyb20gRnV6aG91IFJvY2tjaGlwIEVsZWN0cm9uaWNz IENvLiwgTHRkIC5UaGUgY29udGVudHMgb2YgdGhpcyBlbWFpbCBhbmQgYW55IGF0dGFjaG1lbnRz IG1heQpjb250YWluIGluZm9ybWF0aW9uIHRoYXQgaXMgcHJpdmlsZWdlZCwgY29uZmlkZW50aWFs IGFuZC9vciBleGVtcHQgZnJvbSBkaXNjbG9zdXJlIHVuZGVyIGFwcGxpY2FibGUgbGF3IGFuZCBy ZWxldmFudCBOREEuCklmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZCByZWNpcGllbnQsIHlvdSBh cmUgaGVyZWJ5IG5vdGlmaWVkIHRoYXQgYW55IGRpc2Nsb3N1cmUsIGNvcHlpbmcsIGRpc3RyaWJ1 dGlvbiwgb3IgdXNlIG9mIHRoZQppbmZvcm1hdGlvbiBpcyBTVFJJQ1RMWSBQUk9ISUJJVEVELiBQ bGVhc2UgaW1tZWRpYXRlbHkgY29udGFjdCB0aGUgc2VuZGVyIGFzIHNvb24gYXMgcG9zc2libGUg YW5kIGRlc3Ryb3kgdGhlIG1hdGVyaWFsCmluIGl0cyBlbnRpcmV0eSBpbiBhbnkgZm9ybWF0LiBU aGFuayB5b3UuCioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKgoKCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5n IGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg==