From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:24737 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752597AbbD1BhX (ORCPT ); Mon, 27 Apr 2015 21:37:23 -0400 Message-ID: <553EE44E.8050504@oracle.com> Date: Mon, 27 Apr 2015 21:37:18 -0400 From: Sasha Levin MIME-Version: 1.0 To: Guenter Roeck CC: stable Subject: Re: v3.18-stable-queue build failures References: <553CBE54.7060303@roeck-us.net> <553DAA5A.6060000@oracle.com> <20150427153616.GA5701@roeck-us.net> In-Reply-To: <20150427153616.GA5701@roeck-us.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On 04/27/2015 11:36 AM, Guenter Roeck wrote: > On Sun, Apr 26, 2015 at 11:17:46PM -0400, Sasha Levin wrote: >> On 04/26/2015 06:30 AM, Guenter Roeck wrote: >>> Hi, >>> >>> almost all builds in v3.18-stable-queue fail with >>> >>> In file included from net/socket.c:74:0: >>> include/linux/if_vlan.h: In function 'vlan_put_tag': >>> include/linux/if_vlan.h:409:3: error: implicit declaration of function '__vlan_put_tag' [-Werror=implicit-function-declaration] >>> include/linux/if_vlan.h:409:3: warning: return makes pointer from integer without a cast [enabled by default] >>> >>> groeck@server:~/src/linux-stable$ git grep __vlan_put_tag >>> include/linux/if_vlan.h: return __vlan_put_tag(skb, vlan_proto, vlan_tci); >>> >>> It appears that 'vlan: rename __vlan_put_tag to vlan_insert_tag_set_proto' was incomplete >>> for v3.18. >> >> Thanks! >> >> This was actually missing b4bef1b575 ("vlan: kill vlan_put_tag helper"). >> >> Fixed and re-pushed. >> > Hi Sasha, > > much better now but there are still several build failures. Thanks again! > drivers/net/ethernet/broadcom/bnx2x/bnx2x.h: In function 'bnx2x_fp_busy_poll_init': > drivers/net/ethernet/broadcom/bnx2x/bnx2x.h:625:2: error: implicit declaration of function 'WRITE_ONCE' That's a missing "kernel: Change ASSIGN_ONCE(val, x) to WRITE_ONCE(x, val)". > drivers/net/vxlan.c: In function 'vxlan_xmit_skb': > drivers/net/vxlan.c:1646:2: error: too few arguments to function 'iptunnel_handle_offloads' > include/net/ip_tunnels.h:181:17: note: declared here And this is just a bad backport. Fixed both and repushed. Thanks, Sasha