From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49279)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1Ymz2n-0008Qz-80
	for qemu-devel@nongnu.org; Tue, 28 Apr 2015 02:30:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1Ymz2k-0002Ka-0F
	for qemu-devel@nongnu.org; Tue, 28 Apr 2015 02:30:57 -0400
Received: from szxga01-in.huawei.com ([58.251.152.64]:46505)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1Ymz2j-0002KM-8U
	for qemu-devel@nongnu.org; Tue, 28 Apr 2015 02:30:53 -0400
Message-ID: <553F28F9.1040503@huawei.com>
Date: Tue, 28 Apr 2015 14:30:17 +0800
From: Shannon Zhao <zhaoshenglong@huawei.com>
MIME-Version: 1.0
References: <1429613471-7944-1-git-send-email-shannon.zhao@linaro.org>
	<1429613471-7944-3-git-send-email-shannon.zhao@linaro.org>
	<553ED515.400@linaro.org>
	<20150428075441-mutt-send-email-mst@redhat.com>
In-Reply-To: <20150428075441-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move
 DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, Shannon Zhao <shannon.zhao@linaro.org>
Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, pbonzini@redhat.com, christoffer.dall@linaro.org

On 2015/4/28 13:55, Michael S. Tsirkin wrote:
> Pong.
> You responded to Cornelia's comments on patch 1/2
> with "ok will add".
> I expected v4.
> 

Yeah, but few comments on this patch, so I just want to confirm this
modification is acceptable to virtio-scsi, then will modify the commit
log and send v4.

> On Tue, Apr 28, 2015 at 08:32:21AM +0800, Shannon Zhao wrote:
>> Ping?
>>
>> On 2015/4/21 18:51, shannon.zhao@linaro.org wrote:
>>> From: Shannon Zhao <shannon.zhao@linaro.org>
>>>
>>> Move DEFINE_VIRTIO_SCSI_FEATURES to the backend virtio-scsi.
>>> The transports just sync the host features from backend.
>>>
>>> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
>>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>>> ---
>>>  hw/s390x/s390-virtio-bus.c      | 1 -
>>>  hw/s390x/virtio-ccw.c           | 1 -
>>>  hw/scsi/virtio-scsi.c           | 5 +++++
>>>  hw/virtio/virtio-pci.c          | 1 -
>>>  include/hw/virtio/virtio-scsi.h | 1 +
>>>  5 files changed, 6 insertions(+), 3 deletions(-)
>>
>> -- 
>> Shannon
> 
> .
>