From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ymztt-0008PZ-Jx for qemu-devel@nongnu.org; Tue, 28 Apr 2015 03:25:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ymztq-0001Ny-EK for qemu-devel@nongnu.org; Tue, 28 Apr 2015 03:25:49 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:33177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ymztq-0001NY-9R for qemu-devel@nongnu.org; Tue, 28 Apr 2015 03:25:46 -0400 Received: by pdbnk13 with SMTP id nk13so155219235pdb.0 for ; Tue, 28 Apr 2015 00:25:44 -0700 (PDT) Message-ID: <553F35F1.4010209@ozlabs.ru> Date: Tue, 28 Apr 2015 17:25:37 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <76160645-F63F-4D9E-A228-ECDB92C56CC3@suse.de> <1428485601-26482-1-git-send-email-aik@ozlabs.ru> <20150410021622.GB27440@voom.redhat.com> In-Reply-To: <20150410021622.GB27440@voom.redhat.com> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH qemu v2] qemu-options: Add documentation about PPC64's "-cpu compat" option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf On 04/10/2015 12:16 PM, David Gibson wrote: > On Wed, Apr 08, 2015 at 07:33:21PM +1000, Alexey Kardashevskiy wrote: >> Since 8dfa3a5e "target-ppc: Add "compat" CPU option" (which was a part of >> client-architecture-support patchset) there is a "compat" option >> of "-cpu". However it was not documented at all and this is what this >> patch is trying to do. >> >> Signed-off-by: Alexey Kardashevskiy > > I've updated the previous version in spapr-next. That was bad idea. First of all this patch is missing this: diff --git a/vl.c b/vl.c index 694deb4..12ffa1c 100644 --- a/vl.c +++ b/vl.c @@ -2876,6 +2876,7 @@ int main(int argc, char **argv, char **envp) break; } case QEMU_OPTION_cpu: + case QEMU_OPTION_cpu_ppc: /* hw initialization will check this */ cpu_model = optarg; break; But even with it, "-cpu help" does not work as the "if (!(popt->arch_mask & arch_type))" fails at vl.c:2868 because QEMU_OPTION_cpu does not have PPC64bit set (in order to hide unwanted options on x86) and QEMU_OPTION_cpu_ppc is not "-cpu". We should use the original patch or none at all. -- Alexey