Re: [PATCH v4 1/2] leds: add DT binding for BCM6328 LED controller

[Jacek Anaszewski <j.anaszewski@samsung.com>]

On 04/26/2015 02:15 PM, Álvaro Fernández Rojas wrote:
> This adds device tree binding documentation for the Broadcom BCM6328 LED controller.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> Signed-off-by: Jonas Gorski <jogo@openwrt.org>
> ---
>   v4: introduce changes suggested by Jacek
>   - Follow Documentation convention.
>   v3: introduce changes suggested by Jacek
>   - Revert compatible string to "brcm,bcm6328-leds".
>   - Improved description.
>   - Renamed normal LEDs to hardware controlled.
>   - Explain that LEDs are active high by default on active-low optional property.
>   - Properties are now grouped depending on the type of LED and optional requirement.
>   - Added more examples to explain hardware controlled LEDs and activity/link selection.
>   v2: Introduce changes suggested by Florian and Jonas.
>   - Change compatible string to "brcm,bcm6328-leds-ctrl".
>   - Make valid LEDs statement more strict.
>   - Remove compatible strings from LED subnodes.
>   - Clarify that LEDs are active high by default.
>   - Add a better description for brcm,link-signal-sources and brcm,activity-signal-sources.
>
>   .../devicetree/bindings/leds/leds-bcm6328.txt      | 309 +++++++++++++++++++++
>   1 file changed, 309 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/leds/leds-bcm6328.txt

Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>

-- 
Best Regards,
Jacek Anaszewski