All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Julien Grall <julien.grall@citrix.com>
Cc: xen-devel@lists.xenproject.org, Chen Baozi <baozich@gmail.com>,
	tim@xen.org, ian.campbell@citrix.com,
	stefano.stabellini@citrix.com
Subject: Re: [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI
Date: Tue, 28 Apr 2015 11:31:06 +0100	[thread overview]
Message-ID: <553F616A.3020008@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1504281059540.2640@kaball.uk.xensource.com>

Hi Stefano,

On 28/04/15 11:00, Stefano Stabellini wrote:
> On Mon, 27 Apr 2015, Julien Grall wrote:
>> diff --git a/xen/include/asm-arm/gic_v3_defs.h b/xen/include/asm-arm/gic_v3_defs.h
>> index b8a1c2e..556f114 100644
>> --- a/xen/include/asm-arm/gic_v3_defs.h
>> +++ b/xen/include/asm-arm/gic_v3_defs.h
>> @@ -147,7 +147,7 @@
>>  
>>  #define ICH_SGI_IRQMODE_SHIFT        40
>>  #define ICH_SGI_IRQMODE_MASK         0x1
>> -#define ICH_SGI_TARGET_OTHERS        1
>> +#define ICH_SGI_TARGET_OTHERS        1UL
> 
> Spurious change?

No, this was a mistake when the GICv3 driver has been imported. The
IRQMODE bit is 40 and 1 << 40 would throw the error:

gic-v3.c:847:9: error: left shift count >= width of type [-Werror]
         WRITE_SYSREG(ICH_SGI_TARGET_OTHERS << ICH_SGI_IRQMODE_SHIFT |
         ^

> Aside from this:
> 
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Thanks,

-- 
Julien Grall

  reply	other threads:[~2015-04-28 10:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27 18:31 [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI Julien Grall
2015-04-28 10:00 ` Stefano Stabellini
2015-04-28 10:31   ` Julien Grall [this message]
2015-05-08 14:02     ` Ian Campbell
2015-05-08 14:27       ` Julien Grall
2015-05-08 15:51         ` Ian Campbell
2015-05-08 14:01 ` Ian Campbell
2015-05-08 14:34   ` Julien Grall
2015-05-08 15:51     ` Ian Campbell
2015-05-08 16:55       ` Julien Grall
2015-05-11  8:34         ` Ian Campbell
  -- strict thread matches above, loose matches on Subject: below --
2015-05-08 17:01 Julien Grall
2015-05-09 13:13 ` Chen Baozi
2015-05-21 14:50   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553F616A.3020008@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=baozich@gmail.com \
    --cc=ian.campbell@citrix.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.