From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI Date: Tue, 28 Apr 2015 11:31:06 +0100 Message-ID: <553F616A.3020008@citrix.com> References: <1430159464-24599-1-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Yn2oK-0002B0-Vn for xen-devel@lists.xenproject.org; Tue, 28 Apr 2015 10:32:17 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini , Julien Grall Cc: xen-devel@lists.xenproject.org, Chen Baozi , tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Stefano, On 28/04/15 11:00, Stefano Stabellini wrote: > On Mon, 27 Apr 2015, Julien Grall wrote: >> diff --git a/xen/include/asm-arm/gic_v3_defs.h b/xen/include/asm-arm/gic_v3_defs.h >> index b8a1c2e..556f114 100644 >> --- a/xen/include/asm-arm/gic_v3_defs.h >> +++ b/xen/include/asm-arm/gic_v3_defs.h >> @@ -147,7 +147,7 @@ >> >> #define ICH_SGI_IRQMODE_SHIFT 40 >> #define ICH_SGI_IRQMODE_MASK 0x1 >> -#define ICH_SGI_TARGET_OTHERS 1 >> +#define ICH_SGI_TARGET_OTHERS 1UL > > Spurious change? No, this was a mistake when the GICv3 driver has been imported. The IRQMODE bit is 40 and 1 << 40 would throw the error: gic-v3.c:847:9: error: left shift count >= width of type [-Werror] WRITE_SYSREG(ICH_SGI_TARGET_OTHERS << ICH_SGI_IRQMODE_SHIFT | ^ > Aside from this: > > Acked-by: Stefano Stabellini Thanks, -- Julien Grall