From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Mike Galbraith <umgwanakikbuti@gmail.com>, Tejun Heo <tj@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, Christoph Lameter <cl@linux.com>,
Kevin Hilman <khilman@linaro.org>,
Mike Galbraith <bitbucket@online.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 3/3 V8] workqueue: Allow modifying low level unbound workqueue cpumask
Date: Tue, 28 Apr 2015 18:31:37 +0800 [thread overview]
Message-ID: <553F6189.2070405@cn.fujitsu.com> (raw)
In-Reply-To: <1430195804.3168.19.camel@gmail.com>
On 04/28/2015 12:36 PM, Mike Galbraith wrote:
> On Mon, 2015-04-27 at 23:44 -0400, Tejun Heo wrote:
>
>>> So, we need an API to modify the wq_unbound_cpumask, and I provided
>>> this public function. Otherwise, the other code can't modify it.
>>
>> I see. I don't have too strong an opinion; however, changing the mask
>> is a fairly heavy operation. Are there specific reasons why we don't
>> want to follow the nohz config right away?
>
> Isolation is not only applicable to nohz_full. Many loads are
> unsuitable for nohz_full, yet require maximum isolation.
>
> ATM, nohz_full is not dynamic, but hopefully one day will be. In the
> here and now, we can isolate cores from the scheduler on the fly via
> cpusets, a prime API user candidate.
>
> -Mike
>
So, the public function needs to be kept and the EXPORT_SYMBOL_GPL()
is killed?
next prev parent reply other threads:[~2015-04-28 10:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 9:58 [PATCH 0/3 V8] workqueue: Introduce low-level unbound wq sysfs cpumask Lai Jiangshan
2015-04-27 9:58 ` [PATCH 1/3 V8] workqueue: split apply_workqueue_attrs() into 3 stages Lai Jiangshan
2015-04-27 9:58 ` [PATCH 2/3 V8] workqueue: Create low-level unbound workqueues cpumask Lai Jiangshan
2015-04-27 15:45 ` Tejun Heo
2015-04-27 9:58 ` [PATCH 3/3 V8] workqueue: Allow modifying low level unbound workqueue cpumask Lai Jiangshan
2015-04-27 16:07 ` Tejun Heo
2015-04-28 1:44 ` Lai Jiangshan
2015-04-28 2:24 ` Lai Jiangshan
2015-04-28 3:49 ` Tejun Heo
2015-04-28 10:16 ` Lai Jiangshan
2015-04-30 9:23 ` Lai Jiangshan
2015-04-28 3:44 ` Tejun Heo
2015-04-28 4:36 ` Mike Galbraith
2015-04-28 10:31 ` Lai Jiangshan [this message]
2015-04-28 12:15 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553F6189.2070405@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=bitbucket@online.de \
--cc=cl@linux.com \
--cc=fweisbec@gmail.com \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tj@kernel.org \
--cc=umgwanakikbuti@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.