All of lore.kernel.org
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mpc85xx/T104xD4RDB: Add T104xD4RDB boards support
Date: Tue, 28 Apr 2015 09:13:32 -0700	[thread overview]
Message-ID: <553FB1AC.3030603@freescale.com> (raw)
In-Reply-To: <BY1PR0301MB1208C6FFC95DE679F62B42A4E3E80@BY1PR0301MB1208.namprd03.prod.outlook.com>

Rijay,

On 04/28/2015 04:15 AM, Ciubotariu Codrin Constantin-B43658 wrote:
>>
>>  #ifdef CONFIG_FMAN_ENET
>>  #if defined(CONFIG_T1040RDB) || defined(CONFIG_T1042RDB)
>> -#define CONFIG_SYS_SGMII1_PHY_ADDR		0x03
>> +#define CONFIG_SYS_SGMII1_PHY_ADDR             0x03
>> +#elif defined(CONFIG_T1040D4RDB) || defined(CONFIG_T1042D4RDB)
>> +#define CONFIG_SYS_SGMII1_PHY_ADDR             0x02
>> +#define CONFIG_SYS_SGMII2_PHY_ADDR             0x03
>> +#define CONFIG_SYS_SGMII3_PHY_ADDR             0x01
>> +#endif
> 
> The PHY address for SGMII PHY connected to FM1 at DTSEC3 on T1040D4RDB should be 0x01, not 0x02 (CONFIG_SYS_SGMII1_PHY_ADDR).
> 

Please check the PHY address. If you send a new patch, please rebase to the
latest master. A change is needed in defconfig file.

York

      reply	other threads:[~2015-04-28 16:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25 14:46 [U-Boot] [PATCH] mpc85xx/T104xD4RDB: Add T104xD4RDB boards support Vijay Rai
2015-04-13 17:18 ` York Sun
2015-04-16 19:14 ` York Sun
2015-04-27 19:02   ` York Sun
2015-04-28 11:15 ` Codrin Constantin Ciubotariu
2015-04-28 16:13   ` York Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553FB1AC.3030603@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.