All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 5/6] usb: gadget: atmel_usba: use atmel_io.h to provide on-chip IO
Date: Tue, 28 Apr 2015 18:22:12 +0200	[thread overview]
Message-ID: <553FB3B4.5010708@atmel.com> (raw)
In-Reply-To: <553FA9DE.20406@codethink.co.uk>

Le 28/04/2015 17:40, Ben Dooks a ?crit :
> 
>>>>
>>>> /* Register access macros */ -#ifdef CONFIG_AVR32 -#define
>>>> usba_io_readl	__raw_readl -#define usba_io_writel	__raw_writel 
>>>> -#define usba_io_writew	__raw_writew -#else -#define
>>>> usba_io_readl	readl_relaxed -#define usba_io_writel
>>>> writel_relaxed -#define usba_io_writew	writew_relaxed -#endif 
>>>> +#define usba_io_readl	atmel_oc_readl +#define usba_io_writel
>>>> atmel_oc_writel +#define usba_io_writew	atmel_oc_writew
>>>
>>> Same comment as earlier patch, it would be nice to remove the
>>> define usba_io_{read,write}{l,w} defines in a follow-up patch.
> 
>> I'm fine with this too. Is this targetted at v4.2 ?
> 
> Yes, although we may move it to the soc specific include directories
> to avoid adding more to linux/

BTW, Ben, what _oc_ stands for in the new macro name?

Bye,
-- 
Nicolas Ferre

  reply	other threads:[~2015-04-28 16:22 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26 11:45 [RFC] add avr32/at91 on-chip iO accessors Ben Dooks
2015-03-26 11:45 ` [RFC 1/6] atmel: add atmel_io.h Ben Dooks
2015-03-26 11:51   ` Hans-Christian Egtvedt
2015-03-28 18:20     ` Alexandre Belloni
2015-03-28 23:12       ` Russell King - ARM Linux
2015-03-26 11:45 ` [RFC 2/6] tty: serial: atmel: use atmel_io.h to provide on-chip IO Ben Dooks
2015-03-26 11:45   ` Ben Dooks
2015-03-26 11:45 ` [RFC 3/6] clocksource: tcb_clksrc: " Ben Dooks
2015-03-26 11:45   ` Ben Dooks
2015-03-26 11:54   ` Hans-Christian Egtvedt
2015-03-26 11:54     ` Hans-Christian Egtvedt
     [not found] ` <1427370354-21247-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2015-03-26 11:45   ` [RFC 4/6] spi: atmel: " Ben Dooks
2015-03-26 11:45     ` Ben Dooks
     [not found]     ` <1427370354-21247-5-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2015-03-26 11:55       ` Hans-Christian Egtvedt
2015-03-26 11:55         ` Hans-Christian Egtvedt
2015-03-26 15:38       ` Mark Brown
2015-03-26 15:38         ` Mark Brown
     [not found]         ` <20150326153855.GP3572-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-03-26 15:41           ` Nicolas Ferre
2015-03-26 15:41             ` Nicolas Ferre
     [not found]             ` <551428A9.9090604-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-03-26 16:00               ` Mark Brown
2015-03-26 16:00                 ` Mark Brown
2015-03-26 16:01       ` Mark Brown
2015-03-26 16:01         ` Mark Brown
2015-03-26 11:45 ` [RFC 5/6] usb: gadget: atmel_usba: " Ben Dooks
2015-03-26 11:56   ` Hans-Christian Egtvedt
2015-04-27 20:55     ` Felipe Balbi
2015-04-28 15:40       ` Ben Dooks
2015-04-28 16:22         ` Nicolas Ferre [this message]
2015-04-28 16:30         ` Felipe Balbi
2015-04-28 16:34           ` Ben Dooks
2015-04-28 16:34             ` Felipe Balbi
2015-03-26 11:45 ` [RFC 6/6] mmc: atmel-mci: " Ben Dooks
2015-03-26 11:45   ` Ben Dooks
2015-03-26 11:58   ` Hans-Christian Egtvedt
2015-03-26 11:58     ` Hans-Christian Egtvedt
2015-03-27 17:36 ` [Linux-kernel] [RFC] add avr32/at91 on-chip iO accessors Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553FB3B4.5010708@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.