Re: [PATCH] arch/arm/mach-mvebu/Kconfig: remove obsolete selects

[Gregory CLEMENT <gregory.clement@free-electrons.com>]

Hi Russell,

On 28/04/2015 18:54, Russell King - ARM Linux wrote:
> On Tue, Apr 28, 2015 at 06:41:41PM +0200, Gregory CLEMENT wrote:
>> Hi Valentin,
>>
>> On 28/04/2015 18:02, Valentin Rothberg wrote:
>>> ARM_ERRATA_753970 is not defined in Kconfig, so that both selects turn
>>> out to be nops.  Hence, we can safely remove them.
>>
>> It was already pointed by Paul Bolle a few months ago:
>> http://thread.gmane.org/gmane.linux.kernel/1868817
>>
>> and I thought it was applied.
>>
>> He pointed that the original intent was to select
>> PL310_ERRATA_753970. Initially I was not sure if we needed it. In the
>> meantime I didn't get any answer from the hardware designers but this
>> errata affects the r3p0 version and according to the Cache ID register
>> the PL310 used on these two SoCs were the r3p3.
> 
> It's probably something I need to look at when I'm in a more relaxed
> state, and when I have more time to deal with the dreaded email
> backlog...

Do you see any mistake in my reasoning?

Do you think that errata 753970 could be applied on PL310 version
more recent than the r3p0 one ?

Do you think that Cache ID register could give incorrect information
about the PL310 version?

Or maybe you think about something more global.


Thanks,

Gregory




-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com