From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn9KU-00007Y-6V for qemu-devel@nongnu.org; Tue, 28 Apr 2015 13:29:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yn9KQ-0006xc-2D for qemu-devel@nongnu.org; Tue, 28 Apr 2015 13:29:54 -0400 Received: from resqmta-po-04v.sys.comcast.net ([2001:558:fe16:19:96:114:154:163]:60850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn9KP-0006xQ-QI for qemu-devel@nongnu.org; Tue, 28 Apr 2015 13:29:49 -0400 Message-ID: <553FC38A.7090700@redhat.com> Date: Tue, 28 Apr 2015 11:29:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428206887-7921-1-git-send-email-eblake@redhat.com> <1428206887-7921-17-git-send-email-eblake@redhat.com> <87tww0tzjf.fsf@blackfin.pond.sub.org> In-Reply-To: <87tww0tzjf.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GENEbsm9EwmmkwWuV8Nt7CeMnusEXwKum" Subject: Re: [Qemu-devel] [PATCH v6 16/36] qapi: Use 'alternate' to replace anonymous union List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, berto@igalia.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GENEbsm9EwmmkwWuV8Nt7CeMnusEXwKum Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/28/2015 02:41 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Previous patches have led up to the point where I create the >> new meta-type "'alternate':'Foo'". See the previous patches >> for documentation; I intentionally split as much work into >> earlier patches to minimize the size of this patch, but a lot >> of it is churn due to testsuite fallout after updating to the >> new type. >> >> Signed-off-by: Eric Blake > [...] >> diff --git a/tests/qapi-schema/flat-union-base-union.json b/tests/qapi= -schema/flat-union-base-union.json >> index 838986c..0ba6e28 100644 >> --- a/tests/qapi-schema/flat-union-base-union.json >> +++ b/tests/qapi-schema/flat-union-base-union.json >> @@ -1,4 +1,4 @@ >> -# FIXME: the error message needs help: we require the base to be a st= ruct >> +# we require the base to be a struct >> { 'enum': 'TestEnum', >> 'data': [ 'value1', 'value2' ] } >> { 'type': 'TestTypeA', >=20 > This looks unrelated. Does it belong to PATCH 25? Uggh - more evidence of botched hunk motion across rebase. >=20 > [...] >=20 > Regardless, > Reviewed-by: Markus Armbruster End result is the same, so unless I need to rebase on top of all the other patches going in right now, I won't bother to respin. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GENEbsm9EwmmkwWuV8Nt7CeMnusEXwKum Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVP8OKAAoJEKeha0olJ0Nq8pcH/29B9Zl+laRl3zGGuukQzlKm /qOH7Ej7E+G3Ee/ipoSDGBktN8pccGDxu0HyDMXTDN8PJZGuhQaCX6Fh8zj/UAvb NWz+sfoN18wX8sooGr7zoO070xdDxQdmI68FVgeX6WHVJ5iXUsq4wNzmj4lJasL+ tIL5m/oJTmsd1h15ierXcMYpExAKxrH1rTlR8hjVXd/pVLLQuMxVMVsMQoHRXfSK 9N2lQDyiZqGCqUbFuVcuJ3iaaymvCY718YBdXxZL97ENt4TTpSyBj7o8gNYVDVR1 jteaX8EST74wgdYK3WV0k6UbtmxhiIIBsmSnUswM8PQP1mDH2y2wLLpSglP3nBo= =jtTX -----END PGP SIGNATURE----- --GENEbsm9EwmmkwWuV8Nt7CeMnusEXwKum--