From: Eric Blake <eblake@redhat.com>
To: "Gabriel L. Somlo" <somlo@cmu.edu>, qemu-devel@nongnu.org
Cc: gsomlo@gmail.com, kevin@koconnor.net, kraxel@redhat.com,
brogers@suse.com
Subject: Re: [Qemu-devel] [PATCH v2] bios-tables-test: handle false-positive smbios signature matches
Date: Tue, 28 Apr 2015 14:11:22 -0600 [thread overview]
Message-ID: <553FE96A.7090400@redhat.com> (raw)
In-Reply-To: <1430250938-18478-1-git-send-email-somlo@cmu.edu>
[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]
On 04/28/2015 01:55 PM, Gabriel L. Somlo wrote:
> It has been reported that sometimes the .rodata section of SeaBIOS,
> containing the constant string against which the SMBIOS signature
> ends up being compared, also falls withing the guest f-segment. In
s/withing/within/
> that case, the test obviously fails, unless we continue searching
> for the *real* smbios entry point.
>
> Rather than stopping at the first match for the SMBIOS signature
> ("_SM_") in the f-segment (0xF0000-0xFFFFF), continue scanning
> until either a valid entry point table is found, or the f-segment
> has been exhausted.
>
> Reported-by: Bruce Rogers <brogers@suse.com>
> Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
> Tested-by: Bruce Rogers <brogers@suse.com>
> ---
> tests/bios-tables-test.c | 76 ++++++++++++++++++++++++++++--------------------
> 1 file changed, 44 insertions(+), 32 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-04-28 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 19:55 [Qemu-devel] [PATCH v2] bios-tables-test: handle false-positive smbios signature matches Gabriel L. Somlo
2015-04-28 20:11 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553FE96A.7090400@redhat.com \
--to=eblake@redhat.com \
--cc=brogers@suse.com \
--cc=gsomlo@gmail.com \
--cc=kevin@koconnor.net \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=somlo@cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.