From: Hauke Mehrtens <hauke@hauke-m.de>
To: Eliad Peller <eliad@wizery.com>, Mathy Vanhoef <vanhoefm@gmail.com>
Cc: Arend van Spriel <arend@broadcom.com>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
backports@vger.kernel.org
Subject: Re: [PATCH] backports: fix high RC version parsing in dependency library
Date: Tue, 28 Apr 2015 22:29:04 +0200 [thread overview]
Message-ID: <553FED90.9030301@hauke-m.de> (raw)
In-Reply-To: <CAB3XZEcKBYpxZ8EZnBQX+q1mcX6myLwgzKu=tXKPcESX1bFzsw@mail.gmail.com>
On 04/28/2015 02:25 PM, Eliad Peller wrote:
> On Tue, Apr 28, 2015 at 1:26 PM, Mathy Vanhoef <vanhoefm@gmail.com> wrote:
>> On Tue, Apr 28, 2015 at 10:27 AM, Arend van Spriel <arend@broadcom.com> wrote:
>>> On 04/28/15 01:56, Mathy Vanhoef wrote:
>>>>
>>>> This updates the dependency library to handle RC versions up to 39. For
>>>> example, coccinelle version "1.0.0" is now correctly treated as being
>>>> higher
>>>> than version "1.0.0-rc24".
>>>
>>>
>>> This one is duplicate to the patch Eliad submitted [1]. Any reason for
>>> choosing rc 40?
>>
>> I missed that patched. My reasoning was that previously at least the Linux
>> kernel went up to rc 39 with 2.6.39. So 40 should be a good limit to support
>> most cases.
>>
> note that 39 in this case is the "sublevel", not the "extraversion".
>
> Eliad.
I will take your patch Eliad. There are so many magic numbers in this
code it probably has to get cleaned up, a warning for such a case like
we have it now would also be nice.
Hauke
prev parent reply other threads:[~2015-04-28 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 23:56 [PATCH] backports: fix high RC version parsing in dependency library Mathy Vanhoef
2015-04-28 8:27 ` Arend van Spriel
2015-04-28 10:26 ` Mathy Vanhoef
2015-04-28 12:25 ` Eliad Peller
2015-04-28 20:29 ` Hauke Mehrtens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553FED90.9030301@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=arend@broadcom.com \
--cc=backports@vger.kernel.org \
--cc=eliad@wizery.com \
--cc=mcgrof@kernel.org \
--cc=vanhoefm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.