On 04/04/2015 10:07 PM, Eric Blake wrote: > The previous commit demonstrated that the generator had several > flaws with less-than-perfect enums: > +++ b/tests/qapi-schema/enum-max-member.json > @@ -1,3 +1,3 @@ > -# FIXME: we should either reject user-supplied 'max', or munge the implicit > -# max value we generate at the end of an array > +# we reject user-supplied 'max' for clashing with implicit enum end > +# TODO: should we instead munge the the implicit value to avoid the clash? double "the" needs fixing -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org