From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YnKn3-00060U-Ka for mharc-qemu-trivial@gnu.org; Wed, 29 Apr 2015 01:44:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnKn1-0005x6-DB for qemu-trivial@nongnu.org; Wed, 29 Apr 2015 01:44:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnKn0-0005R2-AA for qemu-trivial@nongnu.org; Wed, 29 Apr 2015 01:44:07 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:59398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnKmu-0005M8-AB; Wed, 29 Apr 2015 01:44:00 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 8E6DE42A19; Wed, 29 Apr 2015 08:43:59 +0300 (MSK) Message-ID: <55406F9F.6090001@msgid.tls.msk.ru> Date: Wed, 29 Apr 2015 08:43:59 +0300 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Peter Crosthwaite , Peter Maydell References: <553E2571.2000700@msgid.tls.msk.ru> In-Reply-To: OpenPGP: id=804465C5 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 86.62.121.231 Cc: QEMU Trivial , Peter Crosthwaite , QEMU Developers , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Peter Crosthwaite Subject: Re: [Qemu-trivial] [PATCH target-arm 2/2] arm: cpu.h: Delete unused cpu_pc_from_tb() X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2015 05:44:08 -0000 27.04.2015 22:06, Peter Crosthwaite wrote: > Does that mean a respin of this patch or should the tricore fix and > the comment be a follow up? Can you please resend whole thing in one change, removing single unused function from two places and updating the comment, to fit all the pieces together? The whole thing is trivial enough to split it up and the definition of "unused" in the subject will be true :) I think that sometimes we make a bit "too trivial" patches which aren't worth a patch by their own :) and the result is unnecessary clutter in the git history. Thanks, /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnKmz-0005wy-H5 for qemu-devel@nongnu.org; Wed, 29 Apr 2015 01:44:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnKmu-0005MC-HS for qemu-devel@nongnu.org; Wed, 29 Apr 2015 01:44:05 -0400 Message-ID: <55406F9F.6090001@msgid.tls.msk.ru> Date: Wed, 29 Apr 2015 08:43:59 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <553E2571.2000700@msgid.tls.msk.ru> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH target-arm 2/2] arm: cpu.h: Delete unused cpu_pc_from_tb() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , Peter Maydell Cc: QEMU Trivial , Peter Crosthwaite , QEMU Developers , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Peter Crosthwaite 27.04.2015 22:06, Peter Crosthwaite wrote: > Does that mean a respin of this patch or should the tricore fix and > the comment be a follow up? Can you please resend whole thing in one change, removing single unused function from two places and updating the comment, to fit all the pieces together? The whole thing is trivial enough to split it up and the definition of "unused" in the subject will be true :) I think that sometimes we make a bit "too trivial" patches which aren't worth a patch by their own :) and the result is unnecessary clutter in the git history. Thanks, /mjt