From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi_scan: fix queue depth initialisation problem
Date: Wed, 29 Apr 2015 08:48:46 +0200 [thread overview]
Message-ID: <55407ECE.3020502@suse.de> (raw)
In-Reply-To: <1430256250.2181.17.camel@HansenPartnership.com>
On 04/28/2015 11:24 PM, James Bottomley wrote:
> From: James Bottomley <JBottomley@Odin.com>
> Date: Sun, 26 Apr 2015 11:52:46 -0700
> Subject: [PATCH] scsi_scan: fix queue depth initialisation problem
>
> Currently we blindly use the value of cmd_per_lun as the initial setting for
> queue_depth. This fails miserably (hangs the system) if it is zero, which is
> the default value for anything uninitialised in the template. The net result
> is that every host template has to set a value for cmd_per_lun. Instead, use
> a default value of 1 if the actual value is unset. This should pave the way
> for removing cmd_per_lun from all the templates and eventually from SCSI
> itself.
>
> Signed-off-by: James Bottomley <JBottomley@Odin.com>
Tested-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-04-29 6:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 21:24 [PATCH] scsi_scan: fix queue depth initialisation problem James Bottomley
2015-04-29 6:48 ` Hannes Reinecke [this message]
2015-05-11 9:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55407ECE.3020502@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.