From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <nadav.amit@gmail.com>, Bandan Das <bsd@redhat.com>
Cc: kvm list <kvm@vger.kernel.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
Wincy Van <fanwenyi0529@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: nVMX: Don't return error on nested bitmap memory allocation failure
Date: Wed, 29 Apr 2015 10:17:35 +0200 [thread overview]
Message-ID: <5540939F.70506@redhat.com> (raw)
In-Reply-To: <9C58F44B-0406-4273-BB36-50D39B7C33F9@gmail.com>
On 29/04/2015 09:27, Nadav Amit wrote:
> free_page appears to check whether the address is zero before it actually
> frees the page. Perhaps it is better to leverage this behaviour to remove
> all the outX and simplify the code.
Agreed. Regarding this patch, I agree with Jan.
Paolo
prev parent reply other threads:[~2015-04-29 8:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 19:55 [PATCH] KVM: nVMX: Don't return error on nested bitmap memory allocation failure Bandan Das
2015-04-29 7:10 ` Jan Kiszka
2015-04-29 12:55 ` Bandan Das
2015-04-29 13:05 ` Jan Kiszka
2015-04-29 13:23 ` Paolo Bonzini
2015-04-29 16:08 ` Bandan Das
2015-04-29 16:39 ` Paolo Bonzini
2015-04-29 7:27 ` Nadav Amit
2015-04-29 8:17 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5540939F.70506@redhat.com \
--to=pbonzini@redhat.com \
--cc=bsd@redhat.com \
--cc=fanwenyi0529@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nadav.amit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.