From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gonzalez Monroy, Sergio" Subject: Re: [PATCH] Simplify the ifdefs in rte.app.mk. Date: Wed, 29 Apr 2015 12:08:54 +0100 Message-ID: <5540BBC6.3090008@intel.com> References: <1430240597-26782-1-git-send-email-keith.wiles@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Thomas Monjalon Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 29/04/2015 11:12, Thomas Monjalon wrote: > Hi Keith, > > Thanks for trying to improve maintainability. > > It seems this is the second version of your patch. > Please add v2 prefix and a changelog to ease review and > patch management. > As you probably know, it is explained here: > http://dpdk.org/dev#send Hi Thomas, Just to clarify as I tend to use RFC PATCH as well, do we still mark it as v2 even though the first patch was an RFC PATCH? Sergio > 2015-04-28 19:03 GMT+02:00 Keith Wiles : >> Trying to simplify the ifdefs in rte.app.mk to make the code >> more readable and maintainable by moving LDLIBS variable to use >> the same style as LDLIBS-y being used in the rest of the code. >> >> Added a new variable called EXTRA_LDLIBS to be used by example apps >> instead of using LDLIBS directly. >> >> Signed-off-by: Keith Wiles