From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v13 10/12] qdev: check callback takes the property child as third argument Date: Wed, 29 Apr 2015 13:12:24 +0200 Message-ID: <5540BC98.1010608@redhat.com> References: <1430239873-31950-1-git-send-email-eric.auger@linaro.org> <1430239873-31950-11-git-send-email-eric.auger@linaro.org> <554094DF.3010607@redhat.com> <55409830.30303@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55409830.30303@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Eric Auger , eric.auger@st.com, qemu-devel@nongnu.org, alex.williamson@redhat.com, agraf@suse.de, peter.crosthwaite@xilinx.com Cc: kvmarm@lists.cs.columbia.edu, patches@linaro.org List-Id: kvmarm@lists.cs.columbia.edu On 29/04/2015 10:37, Eric Auger wrote: >> > This should be an unref. > oups yes. > > Thanks! Do I keep this series or do I revert to sysbus irq connect irq > temporary patch as per Peter's last email? I think reverting is better since you need a respin and Peter offered to touch the code later. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnPuq-0005WL-Q2 for qemu-devel@nongnu.org; Wed, 29 Apr 2015 07:12:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnPun-0007Uv-FS for qemu-devel@nongnu.org; Wed, 29 Apr 2015 07:12:32 -0400 Received: from mail-wg0-x235.google.com ([2a00:1450:400c:c00::235]:33305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnPun-0007Uq-8Q for qemu-devel@nongnu.org; Wed, 29 Apr 2015 07:12:29 -0400 Received: by wgin8 with SMTP id n8so24308703wgi.0 for ; Wed, 29 Apr 2015 04:12:28 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5540BC98.1010608@redhat.com> Date: Wed, 29 Apr 2015 13:12:24 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430239873-31950-1-git-send-email-eric.auger@linaro.org> <1430239873-31950-11-git-send-email-eric.auger@linaro.org> <554094DF.3010607@redhat.com> <55409830.30303@linaro.org> In-Reply-To: <55409830.30303@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v13 10/12] qdev: check callback takes the property child as third argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Auger , eric.auger@st.com, qemu-devel@nongnu.org, alex.williamson@redhat.com, agraf@suse.de, peter.crosthwaite@xilinx.com Cc: kvmarm@lists.cs.columbia.edu, patches@linaro.org On 29/04/2015 10:37, Eric Auger wrote: >> > This should be an unref. > oups yes. > > Thanks! Do I keep this series or do I revert to sysbus irq connect irq > temporary patch as per Peter's last email? I think reverting is better since you need a respin and Peter offered to touch the code later. Paolo