All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Keith Wiles <keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2 2/2] Update Docs for new EXTRA_LDLIBS variable
Date: Wed, 29 Apr 2015 15:55:05 +0100	[thread overview]
Message-ID: <5540F0C9.30806@intel.com> (raw)
In-Reply-To: <1430318263-3189-2-git-send-email-keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On 29/04/2015 15:37, Keith Wiles wrote:
> Signed-off-by: Keith Wiles <keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
>   doc/build-sdk-quick.txt                          | 1 +
>   doc/guides/prog_guide/dev_kit_build_system.rst   | 2 ++
>   doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +-
>   3 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt
> index 041a40e..26d5442 100644
> --- a/doc/build-sdk-quick.txt
> +++ b/doc/build-sdk-quick.txt
> @@ -13,6 +13,7 @@ Build variables
>   	EXTRA_CPPFLAGS   preprocessor options
>   	EXTRA_CFLAGS     compiler options
>   	EXTRA_LDFLAGS    linker options
> +	EXTRA_LDLIBS     linker libary options
>   	RTE_KERNELDIR    linux headers path
>   	CROSS     toolchain prefix
>   	V         verbose
> diff --git a/doc/guides/prog_guide/dev_kit_build_system.rst b/doc/guides/prog_guide/dev_kit_build_system.rst
> index cf5c96f..b8ef167 100644
> --- a/doc/guides/prog_guide/dev_kit_build_system.rst
> +++ b/doc/guides/prog_guide/dev_kit_build_system.rst
> @@ -413,6 +413,8 @@ Variables that Can be Set/Overridden by the User in a Makefile or Command Line
>   
>   *   EXTRA_LDFLAGS: The content of this variable is appended after LDFLAGS when linking.
>   
> +*   EXTRA_LDLIBS: The content of this variable is appended after LDLIBS when linking.
> +
>   *   EXTRA_ASFLAGS: The content of this variable is appended after ASFLAGS when assembling.
>   
>   *   EXTRA_CPPFLAGS: The content of this variable is appended after CPPFLAGS when using a C preprocessor on assembly files.
> diff --git a/doc/guides/prog_guide/dev_kit_root_make_help.rst b/doc/guides/prog_guide/dev_kit_root_make_help.rst
> index 4f30192..fdc5fea 100644
> --- a/doc/guides/prog_guide/dev_kit_root_make_help.rst
> +++ b/doc/guides/prog_guide/dev_kit_root_make_help.rst
> @@ -205,7 +205,7 @@ The following variables can be specified on the command line:
>   
>       Enable dependency debugging. This provides some useful information about why a target is built or not.
>   
> -*   EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_ASFLAGS=, EXTRA_CPPFLAGS=
> +*   EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_LDLIBS=, EXTRA_ASFLAGS=, EXTRA_CPPFLAGS=
>   
>       Append specific compilation, link or asm flags.
>   
Do we need to remove LDLIBS from section 28.3.4?

With the current patch the value of LDLIBS in the app makefile is lost.

Sergio

  parent reply	other threads:[~2015-04-29 14:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 14:37 [PATCH v2 1/2] Simplify the ifdefs in rte.app.mk Keith Wiles
     [not found] ` <1430318263-3189-1-git-send-email-keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-29 14:37   ` [PATCH v2 2/2] Update Docs for new EXTRA_LDLIBS variable Keith Wiles
     [not found]     ` <1430318263-3189-2-git-send-email-keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-29 14:55       ` Gonzalez Monroy, Sergio [this message]
     [not found]         ` <5540F0C9.30806-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-29 15:00           ` Wiles, Keith
     [not found]             ` <D1665C09.1E419%keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-29 15:04               ` Gonzalez Monroy, Sergio
     [not found]                 ` <5540F2FB.1060704-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-29 15:16                   ` Wiles, Keith
     [not found]                     ` <D1665F95.1E42A%keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-29 15:19                       ` Gonzalez Monroy, Sergio
     [not found]                         ` <5540F66D.20104-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-29 15:22                           ` Wiles, Keith
2015-04-29 15:11   ` [PATCH v2 1/2] Simplify the ifdefs in rte.app.mk Bruce Richardson
2015-04-29 15:13     ` Wiles, Keith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5540F0C9.30806@intel.com \
    --to=sergio.gonzalez.monroy-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=keith.wiles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.