Re: [PATCH 02/16] drm/i915: Only remove objects pinned to the display from the available aperture

From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 02/16] drm/i915: Only remove objects pinned to the display from the available aperture
Date: Wed, 29 Apr 2015 16:05:40 +0100	[thread overview]
Message-ID: <5540F344.4040005@linux.intel.com> (raw)
In-Reply-To: <1430138487-22541-3-git-send-email-chris@chris-wilson.co.uk>

On 04/27/2015 01:41 PM, Chris Wilson wrote:
> With the removal of the pin_ioctl, we need only consider
> obj->pin_display when looking at available aperture space.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/i915_gem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index afdb604e4005..ec9e36e9ec78 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -157,7 +157,7 @@ i915_gem_get_aperture_ioctl(struct drm_device *dev, void *data,
>   	pinned = 0;
>   	mutex_lock(&dev->struct_mutex);
>   	list_for_each_entry(obj, &dev_priv->mm.bound_list, global_list)
> -		if (i915_gem_obj_is_pinned(obj))
> +		if (obj->pin_display)
>   			pinned += i915_gem_obj_ggtt_size(obj);
>   	mutex_unlock(&dev->struct_mutex);

The only thing I can think of are transients from execbuf, pre-ppgtt, 
but I suppose we don't care about that a lot? Or I misunderstand how 
something works?

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx