All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
To: ofono@ofono.org
Subject: Re: Cinterion EHS6 support
Date: Wed, 29 Apr 2015 20:24:48 +0200	[thread overview]
Message-ID: <554121F0.4010907@dynamicdevices.co.uk> (raw)
In-Reply-To: <55412050.7080504@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

Hi Denis,

On 29/04/2015 20:17, Denis Kenzior wrote:
> Hi Alex,
>
> On 04/29/2015 11:45 AM, Alex J Lennon wrote:
>> Hi,
>>
>> I've created a patch which adds support for the Cinterion EHS6 to Ofono.
>>
>> This is based on the TC65 source code with some changes to address an
>> issue with +CIND handling
>>
>
> Most likely TC65 has this issue as well.  Are there any other changes ?
>

Yes it does. I started out with the TC65, couldn't get it going and had
to apply that patch to it to get a connection up.

I didn't include the change as am focussed on EHS6 hardware here and
wasn't sure what the impact would be on TC65.
I can provide the TC65 patch easily enough too if you think it useful.

>> The patch is currently in a GitHub fork here
>>
>> https://github.com/DynamicDevices/ofono/commit/06c374b94bef2b3b23c9531c22977976ab7f6e99.patch
>>
>>
>> This enables me to configure an "ehs6" rule in udev and bring up a GPRS
>> connection successfully with Connman.
>>
>> Would it be possible to contribute this to Ofono? If so could somebody
>> let me know what, if anything, needs to be done to the patch?
>>
>
> Generally, just send patches to the mailing list using git send-email.
> They will undergo the review process and will be applied to the
> upstream tree when/if they're ready.
>
> The general submission guidelines are described in git.
> toplevel/HACKING, 'Submitting Patches' section. 


I'll get on with it then.

Many thanks,

Alex


  reply	other threads:[~2015-04-29 18:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 16:45 Cinterion EHS6 support Alex J Lennon
2015-04-29 18:17 ` Denis Kenzior
2015-04-29 18:24   ` Alex J Lennon [this message]
2015-04-29 18:50     ` Denis Kenzior
2015-04-29 19:11       ` Alex J Lennon
2015-04-29 19:17         ` Denis Kenzior
2015-04-29 20:03           ` Alex J Lennon
2015-04-29 20:11             ` Alex J Lennon
2015-04-29 22:57               ` Denis Kenzior
2015-04-30  4:42                 ` Alex J Lennon
2015-04-30  7:37                   ` Alex J Lennon
2015-04-30 17:19                     ` Denis Kenzior
2015-04-30  9:20                   ` Alex J Lennon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554121F0.4010907@dynamicdevices.co.uk \
    --to=ajlennon@dynamicdevices.co.uk \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.