All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: kchamart@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 4/4] scripts: qmp-shell: Add verbose flag
Date: Wed, 29 Apr 2015 13:35:44 -0600	[thread overview]
Message-ID: <55413290.80608@redhat.com> (raw)
In-Reply-To: <1430334844-7015-5-git-send-email-jsnow@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]

On 04/29/2015 01:14 PM, John Snow wrote:
> Add a verbose flag that shows the QMP command that was
> constructed, to allow for later copy/pasting, reference,
> debugging, etc.
> 
> The QMP is converted from a Python literal to JSON first,
> to ensure that it is viable input to the actual QMP parser.
> 
> As a side-effect, this JSON output will helpfully show all
> the necessary conversions that were performed on the input,
> illustrating that "True" was transformed back into "true",
> literal values are now escaped with "" instead of '', and so on.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  scripts/qmp/qmp-shell | 24 ++++++++++++++++++------
>  1 file changed, 18 insertions(+), 6 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2015-04-29 19:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 19:14 [Qemu-devel] [PATCH v4 0/4] scripts: qmp-shell: add transaction support John Snow
2015-04-29 19:14 ` [Qemu-devel] [PATCH v4 1/4] scripts: qmp-shell: refactor helpers John Snow
2015-04-29 19:14 ` [Qemu-devel] [PATCH v4 2/4] scripts: qmp-shell: Expand support for QMP expressions John Snow
2015-04-29 19:25   ` Eric Blake
2015-04-29 20:09     ` John Snow
2015-04-29 19:14 ` [Qemu-devel] [PATCH v4 3/4] scripts: qmp-shell: add transaction subshell John Snow
2015-04-29 19:34   ` Eric Blake
2015-04-29 19:14 ` [Qemu-devel] [PATCH v4 4/4] scripts: qmp-shell: Add verbose flag John Snow
2015-04-29 19:35   ` Eric Blake [this message]
2015-04-30  9:06 ` [Qemu-devel] [PATCH v4 0/4] scripts: qmp-shell: add transaction support Kashyap Chamarthy
2015-05-04 19:24 ` John Snow
2015-05-05 12:52   ` Luiz Capitulino
2015-05-05 15:34     ` John Snow
2015-05-05 20:14       ` Luiz Capitulino
2015-05-08 12:47 ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55413290.80608@redhat.com \
    --to=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kchamart@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.