From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751777AbbD3CDl (ORCPT ); Wed, 29 Apr 2015 22:03:41 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:16371 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbbD3CDh (ORCPT ); Wed, 29 Apr 2015 22:03:37 -0400 X-AuditID: cbfee68f-f793b6d000005f66-74-55418d76cfe3 Message-id: <55418D76.6090904@samsung.com> Date: Thu, 30 Apr 2015 11:03:34 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, jaewon02.kim@samsung.com, myungjoo.ham@samsung.com, kyungmin.park@samsung.com Subject: Re: [PATCH 1/4] extcon: Unify the jig cable names on RT8963 and MAX14577/77693/77843 References: <1430137889-22771-1-git-send-email-cw00.choi@samsung.com> <1430137889-22771-2-git-send-email-cw00.choi@samsung.com> <55418CB5.1020900@samsung.com> In-reply-to: <55418CB5.1020900@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkkeLIzCtJLcpLzFFi42JZI2JSrFvW6xhq0PFf1WJHwxFWi9cvDC3O Nr1ht7i8aw6bxe3GFWwOrB59W1YxenzeJBfAFMVlk5Kak1mWWqRvl8CVcfzQQ7aCj2IVv7ec YWtgnC/YxcjJISFgInH5zz4mCFtM4sK99WxdjFwcQgJLGSXWLTjADFN0ePEKVojEdEaJqS/7 WSCcB4wSxy49ZQGp4hXQknjWMJ0dxGYRUJV4P38ZI4jNBhTf/+IGG4gtKhAmsXL6Fah6QYkf k++B2SIChhIHd28HO4NZoFBi+pQvYHFhgXiJeVN/M0IsW8QosfjFMVaQBKeAtkRv03ugZRxA DXoS9y9qQfTKS2xe85YZpF5CYBG7xIln/UwQBwlIfJt8iAWkXkJAVmITzGeSEgdX3GCZwCg2 C8lJsxCmzkIydQEj8ypG0dSC5ILipPQiY73ixNzi0rx0veT83E2MwBg6/e9Z/w7GuwesDzEK cDAq8fB+aHcMFWJNLCuuzD3EaAp0xERmKdHkfGCk5pXEGxqbGVmYmpgaG5lbmimJ8y6U+hks JJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgVE3TeSm1Z39//OT6/mOrTzzdLVaufRq7zvnxMRD HD9qrdz/eQevieLkig9p2UkTd4SnqT3SmnAy6uC1bvfWA4VLLz5muDTl9mUX2cy/kwWZP7+T FZwffeuQqWijwzN1m/emazRWXIhqODSD7//OeN0JljWmPft8hQ/uPJOydo9PRJVmzwuFcz1K LMUZiYZazEXFiQBblnxnnAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMIsWRmVeSWpSXmKPExsVy+t9jQd2yXsdQg1+TFS12NBxhtXj9wtDi bNMbdovLu+awWdxuXMHmwOrRt2UVo8fnTXIBTFENjDYZqYkpqUUKqXnJ+SmZeem2St7B8c7x pmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QNuUFMoSc0qBQgGJxcVK+naYJoSGuOlawDRG6PqG BMH1GBmggYQ1jBnHDz1kK/goVvF7yxm2Bsb5gl2MnBwSAiYShxevYIWwxSQu3FvP1sXIxSEk MJ1RYurLfhYI5wGjxLFLT1lAqngFtCSeNUxnB7FZBFQl3s9fxghiswHF97+4wQZiiwqESayc fgWqXlDix+R7YLaIgKHEwd3bmUBsZoFCielTvoDFhQXiJeZN/c0IsWwRo8TiF8fATuIU0Jbo bXoPtIwDqEFP4v5FLYheeYnNa94yT2AUmIVkxSyEqllIqhYwMq9iFE0tSC4oTkrPNdIrTswt Ls1L10vOz93ECI7QZ9I7GFc1WBxiFOBgVOLh/dDuGCrEmlhWXJl7iFGCg1lJhHdxJ1CINyWx siq1KD++qDQntfgQoykwACYyS4km5wOTR15JvKGxiZmRpZG5oYWRsbmSOO8cXblQIYH0xJLU 7NTUgtQimD4mDk6pBsZMx11cE1dsODHjkILmxBzHhoic59vOe+2dstbkSpSy1N7XFZ28ebaP 9ygoN/pzPGx1b+565CTuOLnFXW41wzVfzokbzfI6Sks82rf3cl2rPJ0QxrFi0WEj7+KXac1L FUVD9oZ5HrqcmM2VzCCTbvP3vfQFvU+zTMwfTGER0dFvMNT4e0/4gRJLcUaioRZzUXEiAMa4 7tfmAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/30/2015 11:00 AM, Krzysztof Kozlowski wrote: > On 27.04.2015 21:31, Chanwoo Choi wrote: >> This patch change the name of various jig cables as 'JIG' because the name of >> various jig cables are strange and ambiguous on user-space aspect. They include >> the different information of either USB and UART state. It is never important >> for user-space process. This patch unifies the name of jig cables as following: >> - JIG-USB-ON -->|--> JIG >> - JIG-USB-OFF -->| >> - JIG-UART-ON -->| >> - JIG-UART-OFF -->| >> >> Cc: Jaewon Kim >> Cc: Krzysztof Kozlowski >> Signed-off-by: Chanwoo Choi >> --- >> drivers/extcon/extcon-max14577.c | 19 +++---------------- >> drivers/extcon/extcon-max77693.c | 23 +++-------------------- >> drivers/extcon/extcon-max77843.c | 39 ++++++++++++++------------------------- >> drivers/extcon/extcon-rt8973a.c | 22 +++++----------------- >> 4 files changed, 25 insertions(+), 78 deletions(-) >> [snip] >> struct max77843_muic_irq { >> @@ -385,36 +379,31 @@ static int max77843_muic_jig_handler(struct max77843_muic_info *info, >> int cable_type, bool attached) >> { >> int ret; >> + u8 path = CTRL1_SW_OPEN; >> >> dev_dbg(info->dev, "external connector is %s (adc:0x%02x)\n", >> attached ? "attached" : "detached", cable_type); >> >> switch (cable_type) { >> case MAX77843_MUIC_ADC_FACTORY_MODE_USB_OFF: >> - ret = max77843_muic_set_path(info, CONTROL1_SW_USB, attached); >> - if (ret < 0) >> - return ret; >> - extcon_set_cable_state(info->edev, "JIG-USB-OFF", attached); >> - break; >> case MAX77843_MUIC_ADC_FACTORY_MODE_USB_ON: >> - ret = max77843_muic_set_path(info, CONTROL1_SW_USB, attached); >> - if (ret < 0) >> - return ret; >> - extcon_set_cable_state(info->edev, "JIG-USB-ON", attached); >> + path = CONTROL1_SW_USB; >> break; >> case MAX77843_MUIC_ADC_FACTORY_MODE_UART_OFF: >> - ret = max77843_muic_set_path(info, CONTROL1_SW_UART, attached); >> - if (ret < 0) >> - return ret; >> - extcon_set_cable_state(info->edev, "JIG-UART-OFF", attached); >> + path = CONTROL1_SW_UART; >> break; >> default: >> - ret = max77843_muic_set_path(info, CONTROL1_SW_OPEN, attached); >> - if (ret < 0) >> - return ret; >> - break; >> + dev_err(info->dev, "failed to detect %s jig cable\n", >> + attached ? "attached" : "detached"); >> + return -EINVAL; > > The logic for this default case is changed and it is not related to the patch (unification of JIG). Could you split it into separate patch? > > Rest looks fine. OK. I'll split out. Thanks, Chanwoo Choi